Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2024-03-01 Thread MustavData
On Mon, 29 Jan 2024 20:56:42 GMT, Alexey Ivanov wrote: >> I am working to verify the initial fix of JDK-8270269 in OpenJDK 23 (beta). >> The basic environment is: >> >> OpenJDK: "Azul Systems, Inc.", "Zulu23+11-CA", "23-beta+1", "x86_64", >> ".:git:e278d5994c10+" >> OS: Windows 11,

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2024-01-29 Thread Alexey Ivanov
On Fri, 26 Jan 2024 20:11:07 GMT, MustavData wrote: >> Sergey Bylokhov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp >> >> date >> >> Co-authored-by: Alexe

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2024-01-26 Thread MustavData
On Fri, 8 Dec 2023 17:12:29 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2023-12-11 Thread Alexey Ivanov
On Mon, 11 Dec 2023 20:38:46 GMT, Sergey Bylokhov wrote: > A previous call to > [CoInitializeEx](https://learn.microsoft.com/en-us/windows/desktop/api/combaseapi/nf-combaseapi-coinitializeex) > specified the concurrency model for this thread as multithread apartment > (MTA). This could also in

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2023-12-11 Thread Sergey Bylokhov
On Mon, 11 Dec 2023 19:24:34 GMT, Alexey Ivanov wrote: >How come? It can't change: once COM is initialised on a thread, its threading >model cannot be changed. This is what RPC_E_CHANGED_MODE error code conveys, >in other words you request initialising COM in a threading model that's >differen

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2023-12-11 Thread Alexey Ivanov
On Fri, 8 Dec 2023 17:12:29 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2023-12-11 Thread Sergey Bylokhov
On Fri, 8 Dec 2023 17:12:29 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2023-12-08 Thread Alexey Ivanov
On Fri, 8 Dec 2023 17:12:29 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2023-12-08 Thread Sergey Bylokhov
> The fix for a regression caused by the > https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account > RPC_E_CHANGED_MODE when COM was already initialized using > COINIT_MULTITHREADED mode. > > @aivanov-jdk please take a look. Sergey Bylokhov has updated the pull request incre

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Fri, 8 Dec 2023 15:36:40 GMT, Alexey Ivanov wrote: >> Sergey Bylokhov has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8270269: Desktop.browse method fails if earlier CoInitialize call as >> COINIT_MULTITHREADED >> - Revert "6508

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:53:25 GMT, Sergey Bylokhov wrote: >> src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp line 99: >> >>> 97: ::CoUninitialize(); >>> 98: } >>> 99: } >> >> I'm unsure this is the right thing to do. The documentation for >> [`ShellExecute`

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-07 Thread Sergey Bylokhov
On Thu, 7 Dec 2023 15:11:24 GMT, Alexey Ivanov wrote: >> Sergey Bylokhov has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8270269: Desktop.browse method fails if earlier CoInitialize call as >> COINIT_MULTITHREADED >> - Revert "6508

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-07 Thread Sergey Bylokhov
> The fix for a regression caused by the > https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account > RPC_E_CHANGED_MODE when COM was already initialized using > COINIT_MULTITHREADED mode. > > @aivanov-jdk please take a look. Sergey Bylokhov has updated the pull request incre

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED

2023-12-07 Thread Alexey Ivanov
On Thu, 7 Dec 2023 03:03:59 GMT, Sergey Bylokhov wrote: > The fix for a regression caused by the > https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account > RPC_E_CHANGED_MODE when COM was already initialized using > COINIT_MULTITHREADED mode. > > @aivanov-jdk please take a

RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED

2023-12-07 Thread Sergey Bylokhov
The fix for a regression caused by the https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account RPC_E_CHANGED_MODE when COM was already initialized using COINIT_MULTITHREADED mode. @aivanov-jdk please take a look. - Commit messages: - 8270269: Desktop.browse met