Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Fri, 8 Dec 2023 15:36:40 GMT, Alexey Ivanov wrote: >> Sergey Bylokhov has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8270269: Desktop.browse method fails if earlier CoInitialize call as >> COINIT_MULTITHREADED >> - Revert "6508

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:53:25 GMT, Sergey Bylokhov wrote: >> src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp line 99: >> >>> 97: ::CoUninitialize(); >>> 98: } >>> 99: } >> >> I'm unsure this is the right thing to do. The documentation for >> [`ShellExecute`

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-07 Thread Sergey Bylokhov
On Thu, 7 Dec 2023 15:11:24 GMT, Alexey Ivanov wrote: >> Sergey Bylokhov has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8270269: Desktop.browse method fails if earlier CoInitialize call as >> COINIT_MULTITHREADED >> - Revert "6508

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-07 Thread Sergey Bylokhov
> The fix for a regression caused by the > https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account > RPC_E_CHANGED_MODE when COM was already initialized using > COINIT_MULTITHREADED mode. > > @aivanov-jdk please take a look. Sergey Bylokhov has updated the pull request incre