Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v6]

2023-02-28 Thread SWinxy
On Tue, 28 Feb 2023 20:09:04 GMT, SWinxy wrote: >> Many `installDefaults` methods set the font, foreground, and background on >> objects but their inverse methods `uninstallDefaults` do not remove them. >> I've added an inverse method to remove the colors and font to call for the >>

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v6]

2023-02-28 Thread SWinxy
> Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the > `uninstallDefaults` methods that install defaults. > >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v5]

2023-02-28 Thread SWinxy
> Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the > `uninstallDefaults` methods that install defaults. > >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-27 Thread Alexey Ivanov
On Fri, 24 Feb 2023 04:58:12 GMT, Phil Race wrote: > > > And if a default font prevents the FontUIResource from being installed, > > > how does it get installed the in the first place ? > > > Perhaps that first time the component has no peer and it really is null ? > > > > > > The font is

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-23 Thread Phil Race
On Fri, 24 Feb 2023 01:37:44 GMT, SWinxy wrote: > > And if a default font prevents the FontUIResource from being installed, how > > does it get installed the in the first place ? > > Perhaps that first time the component has no peer and it really is null ? > > The font is null when it's

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-23 Thread SWinxy
On Fri, 24 Feb 2023 00:07:20 GMT, Phil Race wrote: > And if a default font prevents the FontUIResource from being installed, how > does it get installed the in the first place ? Perhaps that first time the component has no peer and it really is null ? The font is null when it's created.

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-23 Thread Phil Race
On Mon, 20 Feb 2023 08:08:22 GMT, SWinxy wrote: > Figured it out. When setting a Component's font to null, it inherits the font > from the component tree. Good to know but .. > Changing the fallback font type to a FontUIResource in the peers fixes this. Sorry, but I don't think we should do

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-20 Thread SWinxy
On Sun, 19 Feb 2023 09:35:53 GMT, SWinxy wrote: >> Many `installDefaults` methods set the font, foreground, and background on >> objects but their inverse methods `uninstallDefaults` do not remove them. >> I've added an inverse method to remove the colors and font to call for the >>

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v4]

2023-02-20 Thread SWinxy
> Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the > `uninstallDefaults` methods that install defaults. > >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-19 Thread Julian Waters
On Sun, 19 Feb 2023 09:35:53 GMT, SWinxy wrote: >> Many `installDefaults` methods set the font, foreground, and background on >> objects but their inverse methods `uninstallDefaults` do not remove them. >> I've added an inverse method to remove the colors and font to call for the >>

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-19 Thread SWinxy
On Sun, 19 Feb 2023 09:35:53 GMT, SWinxy wrote: >> Many `installDefaults` methods set the font, foreground, and background on >> objects but their inverse methods `uninstallDefaults` do not remove them. >> I've added an inverse method to remove the colors and font to call for the >>

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-19 Thread SWinxy
> Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the > `uninstallDefaults` methods that install defaults. > >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v2]

2023-02-03 Thread SWinxy
On Mon, 19 Dec 2022 21:43:26 GMT, Alexey Ivanov wrote: >>> This change cause 23 test cases to fail across the platforms: >> >> So I thought we'd got past the testing since a CSR was proposed. The CSR >> should have waited. >> >>> >>> * `sanity/client/SwingSet/src/SwingSet2DemoTest.java`; >>>

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v2]

2022-12-19 Thread Alexey Ivanov
On Thu, 15 Dec 2022 23:41:30 GMT, Phil Race wrote: > One JCK test fails; from a quick look, it's because the font is now > uninstalled where it wasn't previously. I confirmed it's a test problem. The JCK test needs to be updated. Details are in a confidential comment in JCK. Do I need to

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v2]

2022-12-15 Thread SWinxy
On Thu, 15 Dec 2022 23:41:30 GMT, Phil Race wrote: > So all the test failures are blocker problem 100%. I'll see what I can learn from the failed tests, but my hunch is that many fail due to incorrect assumptions. - PR: https://git.openjdk.org/jdk/pull/10565

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v2]

2022-12-15 Thread Phil Race
On Wed, 14 Dec 2022 21:42:37 GMT, Alexey Ivanov wrote: > This change cause 23 test cases to fail across the platforms: So I thought we'd got past the testing since a CSR was proposed. The CSR should have waited. > > * `sanity/client/SwingSet/src/SwingSet2DemoTest.java`; > *

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v2]

2022-12-14 Thread Alexey Ivanov
On Mon, 12 Dec 2022 18:27:24 GMT, SWinxy wrote: >> Many `installDefaults` methods set the font, foreground, and background on >> objects but their inverse methods `uninstallDefaults` do not remove them. >> I've added an inverse method to remove the colors and font to call for the >>

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-12-12 Thread SWinxy
On Mon, 12 Dec 2022 17:37:24 GMT, Phil Race wrote: > I have made a number of edits to the CSR. There is some rewording which you > need to copy back to here. Also I didn't see the need to include the @see > changes in other methods in the CSR. They are not spec-relevant and clutter it Done.

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v2]

2022-12-12 Thread SWinxy
> Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the > `uninstallDefaults` methods that install defaults. > >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-12-12 Thread Phil Race
On Tue, 4 Oct 2022 22:52:30 GMT, SWinxy wrote: > Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-12-07 Thread Julian Waters
On Tue, 4 Oct 2022 22:52:30 GMT, SWinxy wrote: > Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-11-04 Thread Phil Race
On Tue, 4 Oct 2022 22:52:30 GMT, SWinxy wrote: > Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-11-03 Thread Phil Race
On Thu, 3 Nov 2022 22:07:14 GMT, SWinxy wrote: > Can the CSR be skipped if the methods are made package-private? Well, yes, except you can't do that because they are called from other packages. - PR: https://git.openjdk.org/jdk/pull/10565

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-11-03 Thread SWinxy
On Tue, 4 Oct 2022 22:52:30 GMT, SWinxy wrote: > Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-11-03 Thread Phil Race
On Tue, 4 Oct 2022 22:52:30 GMT, SWinxy wrote: > Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the >

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-11-02 Thread Alexey Ivanov
On Tue, 4 Oct 2022 22:52:30 GMT, SWinxy wrote: > Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the >

RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2022-10-04 Thread SWinxy
Many `installDefaults` methods set the font, foreground, and background on objects but their inverse methods `uninstallDefaults` do not remove them. I've added an inverse method to remove the colors and font to call for the `uninstallDefaults` methods that install defaults. `AquaButtonUI` can