Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v7]

2022-08-09 Thread Prasanta Sadhukhan
On Mon, 8 Aug 2022 04:13:17 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v7]

2022-08-09 Thread Tejesh R
On Tue, 9 Aug 2022 15:01:48 GMT, Tejesh R wrote: > Since JBS says the problem is seen when "L&F used is Nimbus " and you made > changes in BasicFileChooserUI which will affect all L&F, please confirm that > it is working for all L&F in windows (Metal, Nimbus, Windows, WindowsClassic) @prsadhuk

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v7]

2022-08-09 Thread Tejesh R
On Tue, 9 Aug 2022 12:18:16 GMT, Prasanta Sadhukhan wrote: > Since JBS says the problem is seen when "L&F used is Nimbus " and you made > changes in BasicFileChooserUI which will affect all L&F, please confirm that > it is working for all L&F in windows (Metal, Nimbus, Windows, WindowsClassic)

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v7]

2022-08-09 Thread Prasanta Sadhukhan
On Mon, 8 Aug 2022 04:13:17 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v7]

2022-08-08 Thread Alexey Ivanov
On Mon, 8 Aug 2022 04:13:17 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v7]

2022-08-07 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v6]

2022-08-05 Thread Dio Brando
On Fri, 5 Aug 2022 05:46:20 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v6]

2022-08-05 Thread Alexey Ivanov
On Fri, 5 Aug 2022 05:46:20 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v5]

2022-08-04 Thread Tejesh R
On Thu, 4 Aug 2022 18:53:30 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > Changes requested by aivanov (Reviewer). @aivanov-jdk Updated your review comments. L

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v6]

2022-08-04 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v5]

2022-08-04 Thread Alexey Ivanov
On Thu, 4 Aug 2022 18:45:21 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v5]

2022-08-04 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v4]

2022-08-04 Thread Tejesh R
On Thu, 4 Aug 2022 15:32:17 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix for multi selection and updated the test to handle both single and >> multi selection > > It works fine now. Thank you

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v4]

2022-08-04 Thread Alexey Ivanov
On Thu, 4 Aug 2022 12:08:15 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

2022-08-04 Thread Alexey Ivanov
On Wed, 3 Aug 2022 15:50:37 GMT, Tejesh R wrote: > In the single-selection case, I see the following output: > > ``` > Absolute Path : null > Absolute Path : C:\filechooser\link > ``` Sorry about that. Upon re-testing, this scenario worked fine with your original changes. > For link it doesn'

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v4]

2022-08-04 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v3]

2022-08-04 Thread Tejesh R
On Wed, 3 Aug 2022 15:14:22 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Added Dialog information for printing Absolute path >> - Updated based on review comments > > Changes requested by aivan

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v3]

2022-08-03 Thread Tejesh R
On Wed, 3 Aug 2022 15:14:08 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Added Dialog information for printing Absolute path >> - Updated based on review comments > > test/jdk/javax/swing/JFile

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v3]

2022-08-03 Thread Tejesh R
On Wed, 3 Aug 2022 15:11:27 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Added Dialog information for printing Absolute path >> - Updated based on review comments > > test/jdk/javax/swing/JFile

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

2022-08-03 Thread Tejesh R
On Wed, 3 Aug 2022 15:47:25 GMT, Tejesh R wrote: > > It does not work. > > In the single-selection case, I see the following output: > > ``` > > Absolute Path : null > > Absolute Path : C:\filechooser\link > > ``` > > > > > > > > > > > > > > > > > > > > > >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

2022-08-03 Thread Tejesh R
On Wed, 3 Aug 2022 13:10:15 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix : Updated to handle multiSelection case >> - Manual Test Indicator Added in JTREG tag > > test/jdk/javax/swing/JFile

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v3]

2022-08-03 Thread Alexey Ivanov
On Wed, 3 Aug 2022 14:04:34 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v3]

2022-08-03 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

2022-08-03 Thread Alexey Ivanov
On Wed, 3 Aug 2022 07:55:33 GMT, Tejesh R wrote: >> test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java line 76: >> >>> 74: 2. Create a Symbolic link targeting the created test >>> directory. >>> 75: ex : mklink /D c:\\link c:\\target >>> 76:

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

2022-08-03 Thread Alexey Ivanov
On Mon, 1 Aug 2022 10:27:03 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

2022-08-03 Thread Tejesh R
On Fri, 29 Jul 2022 18:07:40 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix : Updated to handle multiSelection case >> - Manual Test Indicator Added in JTREG tag > > test/jdk/javax/swing/JFil

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

2022-08-01 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser

2022-08-01 Thread Tejesh R
On Fri, 29 Jul 2022 18:28:45 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java >> line 749: >> >>> 747: } else { >>> 748: chooser.setSelectedFile(null); >>> 749:

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser

2022-07-29 Thread Alexey Ivanov
On Fri, 29 Jul 2022 18:14:14 GMT, Alexey Ivanov wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChoo

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser

2022-07-29 Thread Alexey Ivanov
On Thu, 21 Jul 2022 18:31:46 GMT, Tejesh R wrote: > Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The

RFR: 8281966: Absolute path of symlink is null in JFileChooser

2022-07-21 Thread Tejesh R
Absolute path of Symbolic Link created in Windows is set to `null` in `BasicFileChooserUI` class. This happens when propertyChangeListener is implemented to get the Symbolic link's Absolute path on Mouse click through JFileChooser. The reason being that on click of Symbolic link, the _ValueChan