Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard [v2]

On Tue, 24 Jan 2023 20:14:20 GMT, Alisen Chung wrote: >> Removed check for MapVirtualKeyEx return value causing some keys to become >> undefined > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > readded check for dead key

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard [v2]

> Removed check for MapVirtualKeyEx return value causing some keys to become > undefined Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: readded check for dead key leading bit, added separate check for group separator

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

On Tue, 17 Jan 2023 22:13:18 GMT, Alisen Chung wrote: >> Removed check for MapVirtualKeyEx return value causing some keys to become >> undefined > > My (US QWERTY) keyboard doesn't have a key between the Z and L shift keys, so > I used the on screen keyboard in German. I typed the OEM 102 key

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

On Fri, 6 Jan 2023 22:07:33 GMT, Alisen Chung wrote: > Removed check for MapVirtualKeyEx return value causing some keys to become > undefined My (US QWERTY) keyboard doesn't have a key between the Z and L shift keys, so I used the on screen keyboard in German. I typed the OEM 102 key and C x2

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

On Fri, 6 Jan 2023 22:07:33 GMT, Alisen Chung wrote: > Removed check for MapVirtualKeyEx return value causing some keys to become > undefined Hello, guys! I've just checked behavior of the fix and it actually breaks the case described in the

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

On Fri, 6 Jan 2023 22:07:33 GMT, Alisen Chung wrote: > Removed check for MapVirtualKeyEx return value causing some keys to become > undefined I checked that the behavior of the test in https://bugs.openjdk.org/browse/JDK-8139189 is unchanged - PR:

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

On Fri, 6 Jan 2023 22:07:33 GMT, Alisen Chung wrote: > Removed check for MapVirtualKeyEx return value causing some keys to become > undefined That check was added as part of the https://bugs.openjdk.org/browse/JDK-8139189, can we check that functionality is not broken by the current change?

RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

Removed check for MapVirtualKeyEx return value causing some keys to become undefined - Commit messages: - removed check for 0x8000 in character for dead key Changes: https://git.openjdk.org/jdk/pull/11887/files Webrev: https://webrevs.openjdk.org/?repo=jdk=11887=00 Issue: