Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-04 Thread Abhishek Kumar
On Tue, 4 Jul 2023 18:01:06 GMT, Alexey Ivanov wrote: > And this seems to be the problem. The getAccessibleName method should be on > JComboBox, or its editor, which should return the result of getAccessibleName > of the renderer component. Since the a11y APIs are called upon the `AquaComboBox

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-04 Thread Alexey Ivanov
On Tue, 4 Jul 2023 14:52:14 GMT, Abhishek Kumar wrote: > But in case of JComboBox, a11y API invokes the `getAccessibleName` method for > `AccessibleJButton` and that returns an empty string. And this seems to be the problem. The `getAccessibleName` method should be on JComboBox, or its editor,

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-04 Thread Abhishek Kumar
On Tue, 4 Jul 2023 14:17:51 GMT, Alexey Ivanov wrote: > It means you have to look into how it's done in JList so that JCheckBox works > in a similar way. For a JList, whenever `setText` is invoked from renderer's `getListCellRendererComponent` method, JLabel's text is set to the value display

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-04 Thread Alexey Ivanov
On Tue, 4 Jul 2023 09:28:14 GMT, Abhishek Kumar wrote: >>> This doesn't really answer the question. Do JTable and JList correctly >>> display the magnified text when a custom renderer is used? In the case with >>> rectangle and a custom renderer? Do they still display text from toString? >> >>

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-04 Thread Abhishek Kumar
On Tue, 4 Jul 2023 09:03:00 GMT, Abhishek Kumar wrote: >> How does `JTable` handle the situation where an image is displayed? You can >> use SwingSet2 for testing: it displays colored text and images. > >> This doesn't really answer the question. Do JTable and JList correctly >> display the mag

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-04 Thread Abhishek Kumar
On Mon, 3 Jul 2023 11:16:12 GMT, Alexey Ivanov wrote: >>> > What if `JComboBox` uses a non-standard renderer which takes a property >>> > from an object? Let's assume, `JComboBox` is populated with `Rectangle` >>> > objects, a custom renderer is set which displays the value of the >>> > `botto

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-03 Thread Alexey Ivanov
On Mon, 3 Jul 2023 11:11:47 GMT, Alexey Ivanov wrote: >>> What if `JComboBox` uses a non-standard renderer which takes a property >>> from an object? Let's assume, `JComboBox` is populated with `Rectangle` >>> objects, a custom renderer is set which displays the value of the `bottom` >>> field

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-03 Thread Alexey Ivanov
On Mon, 3 Jul 2023 09:14:23 GMT, Abhishek Kumar wrote: > > What if `JComboBox` uses a non-standard renderer which takes a property > > from an object? Let's assume, `JComboBox` is populated with `Rectangle` > > objects, a custom renderer is set which displays the value of the `bottom` > > fiel

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-07-03 Thread Abhishek Kumar
On Fri, 30 Jun 2023 19:36:43 GMT, Alexey Ivanov wrote: >> I need to check with custom renderer. >> >> If I understand correctly, with current fix the `getSelectedItem` method >> will return the `rectangle` object and then calling `toString` method will >> return rectangle's dimension instead

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-06-30 Thread Alexey Ivanov
On Fri, 30 Jun 2023 11:16:27 GMT, Abhishek Kumar wrote: > If I understand correctly, with current fix the `getSelectedItem` method will > return the `rectangle` object and then calling `toString` method will return > rectangle's dimension instead of the displayed text in JComboBox and that may

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-06-30 Thread Abhishek Kumar
On Fri, 30 Jun 2023 10:38:01 GMT, Alexey Ivanov wrote: >> I tried with the `Integer` object and it works fine. Please suggest if >> anything else I can test. > >> I tried with the `Integer` object and it works fine. Please suggest if >> anything else I can test. > > Obviously, it does. > > Wh

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-06-30 Thread Alexey Ivanov
On Fri, 30 Jun 2023 07:46:22 GMT, Abhishek Kumar wrote: > I tried with the `Integer` object and it works fine. Please suggest if > anything else I can test. Obviously, it does. What about a custom object which doesn't override `toString`? Although this shouldn't be a problem either. What if

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-06-30 Thread Abhishek Kumar
On Thu, 29 Jun 2023 20:43:00 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java >> line 1141: >> >>> 1139: return(Accessible) popup; >>> 1140: } >>> 1141: break; >> >> Why do you change indentation? To

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-06-30 Thread Abhishek Kumar
On Thu, 29 Jun 2023 13:39:26 GMT, Alexey Ivanov wrote: >> I tested several times, didn't get such kind of result and as per java docs >> toString method returns `a string representation of the object.` So, I think >> it will be a valid string. > > An interesting question… it depends on the obje

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

2023-06-30 Thread Abhishek Kumar
> The issue exist only for non-editable combobox and the root cause is > accessible object is not created due to incorrect index returned from > component class which results in no a11y API invoked. > > Proposed solution is to return the correct accessible child from > getAccessibleChild method