On Thu, 22 Sep 2022 20:19:12 GMT, Alexey Ivanov wrote:
>> I unfortunately don't have a JBS (yet..), so if you could, that would be
>> amazing.
>
> I think the text is correct here: …that _**a** Theme_ can support
>
> `MetalTheme` is a superclass for classes which implement Themes. Thus the
>
On Wed, 21 Sep 2022 11:52:57 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> I ignored typos in public methods and variables. Maybe they can be fixed
>> later on without much
On Thu, 22 Sep 2022 16:59:34 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/sun/awt/SunToolkit.java line 1434:
>>
>>> 1432:
>>> 1433: /**
>>> 1434: * Parameterless version of realsync which uses default timeout
>>> (see DEFAULT_WAIT_TIME).
>>
>> Suggestion:
>>
>>
On Thu, 22 Sep 2022 17:21:05 GMT, SWinxy wrote:
>> Please submit a new JBS issue for it if you can; if you can't, I can submit
>> one on your behalf.
>>
>> Possibly it meant to say “_the_ theme”.
>
> I unfortunately don't have a JBS (yet..), so if you could, that would be
> amazing.
I think
On Thu, 22 Sep 2022 16:54:39 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalTheme.java line
>> 68:
>>
>>> 66: public abstract class MetalTheme {
>>> 67:
>>> 68: // Constants identifying the various Fonts that a Theme can support
>>
>> I think this
On Thu, 22 Sep 2022 01:35:49 GMT, SWinxy wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 49 commits:
>>
>> - Merge branch 'master' into typos-in-java.desktop
>> - Revert changes to glext.h
>> -
On Thu, 22 Sep 2022 01:29:24 GMT, SWinxy wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 49 commits:
>>
>> - Merge branch 'master' into typos-in-java.desktop
>> - Revert changes to glext.h
>> -
On Wed, 21 Sep 2022 11:52:57 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> I ignored typos in public methods and variables. Maybe they can be fixed
>> later on without much
On Wed, 21 Sep 2022 11:52:57 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> I ignored typos in public methods and variables. Maybe they can be fixed
>> later on without much
On Wed, 21 Sep 2022 11:52:57 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> I ignored typos in public methods and variables. Maybe they can be fixed
>> later on without much
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs
11 matches
Mail list logo
