Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-16 Thread Abhishek Kumar
On Tue, 16 Aug 2022 19:21:12 GMT, Phil Race wrote: >> It's reachable when `listViewWindowsStyle` is `false`, which seems to be the >> case in all the Look-and-Feels but Windows one. >> >> Yet it looks confusing. > >> It's reachable when `listViewWindowsStyle` is `false`, which seems to be the

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-16 Thread Phil Race
On Thu, 11 Aug 2022 19:36:35 GMT, Alexey Ivanov wrote: > It's reachable when `listViewWindowsStyle` is `false`, which seems to be the > case in all the Look-and-Feels but Windows one. > > Yet it looks confusing. We have if (listViewWindowsStyle) { ..

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-12 Thread Abhishek Kumar
On Fri, 12 Aug 2022 18:35:11 GMT, Alexey Ivanov wrote: >> MessageFormat.format method was truncating "0" from values like "0.0", "1.0" >> and so on. >> Due to that I initialize MessageFormat and NumberFormat instance. >> >> The first parameter in updateMessageFormatPattern method changes based

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-12 Thread Alexey Ivanov
On Fri, 12 Aug 2022 14:49:18 GMT, Abhishek Kumar wrote: > MessageFormat.format method was truncating "0" from values like "0.0", "1.0" > and so on. Due to that I initialize MessageFormat and NumberFormat instance. Got it. > The first parameter in updateMessageFormatPattern method changes based

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-12 Thread Abhishek Kumar
On Thu, 11 Aug 2022 19:11:28 GMT, Alexey Ivanov wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Smaller file sizes display one decimal precision > > src/java.desktop/share/classes/sun/swing/FilePane.java line 119

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Alexey Ivanov
On Thu, 11 Aug 2022 19:30:18 GMT, Phil Race wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Smaller file sizes display one decimal precision > > src/java.desktop/share/classes/sun/swing/FilePane.java line 1209: >

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Alexey Ivanov
On Thu, 11 Aug 2022 10:02:56 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Phil Race
On Thu, 11 Aug 2022 10:02:56 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Abhishek Kumar
On Thu, 11 Aug 2022 10:02:56 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Abhishek Kumar
> JFileChooser - empty file size issue fixed. > For empty file, now the size 0 KB. > Manual Test Case "FileSizeCheck.java" created. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Smaller file sizes display one decimal precision -