Re: RFR: 8295369: Update LCMS to 2.14 [v3]

2022-11-14 Thread Phil Race
On Mon, 14 Nov 2022 19:09:40 GMT, Alisen Chung wrote: >> These look to me like tabs have not been replaced by spaces.. >> I saw a lot of "shifts" and I spot-checked some of them but they looked like >> ones where upstream had readily changed indentation. >> This does not look like that. > > I'm

Re: RFR: 8295369: Update LCMS to 2.14 [v3]

2022-11-14 Thread Alisen Chung
On Thu, 10 Nov 2022 23:28:13 GMT, Phil Race wrote: >> src/java.desktop/share/native/liblcms/cmscgats.c line 2389: >> >>> 2387: >>> 2388: SetData(it8, i, idField, Buffer); >>> 2389: } >> >> Are these shifts caused by ou

Re: RFR: 8295369: Update LCMS to 2.14 [v3]

2022-11-10 Thread Phil Race
On Thu, 10 Nov 2022 22:58:54 GMT, Sergey Bylokhov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated UPDATING.txt contents > > src/java.desktop/share/native/liblcms/cmscgats.c line 2389: > >> 2387: >> 2388:

Re: RFR: 8295369: Update LCMS to 2.14 [v3]

2022-11-10 Thread Sergey Bylokhov
On Tue, 8 Nov 2022 22:03:44 GMT, Alisen Chung wrote: >> Updating LCMS to newest release > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > updated UPDATING.txt contents src/java.desktop/share/native/liblcms/cmscgats.c line 23

Re: RFR: 8295369: Update LCMS to 2.14 [v3]

2022-11-08 Thread Alisen Chung
> Updating LCMS to newest release Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: updated UPDATING.txt contents - Changes: - all: https://git.openjdk.org/jdk/pull/11000/files - new: https://git.openjdk.org/jdk/pull/1