Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent [v4]

2022-11-17 Thread Harshitha Onkar
On Thu, 17 Nov 2022 11:27:07 GMT, Alexey Ivanov wrote: >> Tested it locally on Win10. Works as expected. I agree with @prrace, adding >> additional delay would make sure that all events are processed. > > Without explicit `Robot.waitForIdle()` calls, the test looks as if > something's missing.

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent [v4]

2022-11-17 Thread ravi gupta
On Thu, 17 Nov 2022 11:27:07 GMT, Alexey Ivanov wrote: >> Tested it locally on Win10. Works as expected. I agree with @prrace, adding >> additional delay would make sure that all events are processed. > > Without explicit `Robot.waitForIdle()` calls, the test looks as if > something's missing.

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-17 Thread Alexey Ivanov
On Wed, 16 Nov 2022 19:58:27 GMT, Harshitha Onkar wrote: >> test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java line 72: >> >>> 70: >>> 71: typeKey(KeyEvent.VK_T); >>> 72: >> >> In theory the autoWaitForIdle should ensure that events are processed. We'll >> see. >>

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-17 Thread Alexey Ivanov
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-16 Thread Harshitha Onkar
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-16 Thread Harshitha Onkar
On Wed, 16 Nov 2022 19:13:57 GMT, Phil Race wrote: >> ravi gupta has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8296632: Review fixes. > > test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java line 72: > >> 70: >> 71:

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-16 Thread Phil Race
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-16 Thread ravi gupta
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-14 Thread lawrence . andrews
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-13 Thread ravi gupta
On Fri, 11 Nov 2022 16:48:45 GMT, lawrence.andrews wrote: >> ravi gupta has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8296632: Review fixes. > > test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java line 2: > >> 1: /* >> 2

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-11 Thread lawrence . andrews
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-11 Thread Manukumar V S
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-11 Thread ravi gupta
> This testcase Verify the content changes of a TextArea for the following > assertions. > > a. TextListener get invoked when the content of a TextArea gets changed. > b. TextListener not get invoked during text selection or when Special keys > such as Function Keys are pressed. > > > Testing: