Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

> On Dec 27, 2022, at 1:43 PM, Xue-Lei Andrew Fan wrote: > > On Tue, 27 Dec 2022 14:40:36 GMT, Christoph wrote: > >> ERROR: Build failed for target 'run-test-tier1' in configuration >> 'macosx-aarch64-server-release' (exit code 2) >> > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-829

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

On Tue, 27 Dec 2022 14:40:36 GMT, Christoph wrote: > ERROR: Build failed for target 'run-test-tier1' in configuration > 'macosx-aarch64-server-release' (exit code 2) > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) was filled to track the issue. Thanks! - PR: https:

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

On Thu, 8 Dec 2022 19:41:16 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

> On Dec 9, 2022, at 11:57 AM, Laurent Bourgès wrote: > > On Thu, 8 Dec 2022 19:41:16 GMT, Xue-Lei Andrew Fan > wrote: > >>> Hi, >>> >>> May I have this update reviewed? >>> >>> The sprintf is deprecated in Xcode 14 because of security concerns, and the >>> use of it causing building fai

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

On Thu, 8 Dec 2022 19:41:16 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

On Thu, 8 Dec 2022 17:19:56 GMT, Kim Barrett wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update on review feedback > > src/hotspot/share/adlc/formssel.cpp line 28: > >> 26: #include "adlc.hpp" >> 27: >>

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

> On Dec 7, 2022, at 9:23 PM, Xue-Lei Andrew Fan wrote: > > On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan > wrote: > >>> Hi, >>> >>> May I have this update reviewed? >>> >>> The sprintf is deprecated in Xcode 14 because of security concerns, and the >>> use

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

On Wed, 7 Dec 2022 08:46:45 GMT, Thomas Stuefe wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment for snprintf_checked > > src/hotspot/share/adlc/output_c.cpp line 46: > >> 44: va_end(args); >> 45:

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

On Wed, 7 Dec 2022 16:00:04 GMT, Laurent Bourgès wrote: >> src/hotspot/os/bsd/attachListener_bsd.cpp line 260: >> >>> 258: // name ("load", "datadump", ...), and is an argument >>> 259: int expected_str_count = 2 + AttachOperation::arg_count_max; >>> 260: const int max_len = (ver_str_len

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

On Wed, 7 Dec 2022 08:35:52 GMT, Thomas Stuefe wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment for snprintf_checked > > src/hotspot/os/bsd/attachListener_bsd.cpp line 260: > >> 258: // name ("load"

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

> On Dec 7, 2022, at 3:41 AM, Thomas Stuefe wrote: > > am surprised this even builds. It builds for me… * Toolchain: clang (clang/LLVM from Xcode 14.1) With the exception of these errors in cmstypes.c /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:344

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v12]

On Sun, 27 Nov 2022 07:57:46 GMT, Thomas Stuefe wrote: > How about renaming the existing os::snprintf to something like > os::snprintf_unchecked, make os::snprintf the checked version, ... The name `snprintf` may implies the function in C. For that purpose, I may use a name different from`snp

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v12]

On Sun, 27 Nov 2022 07:57:46 GMT, Thomas Stuefe wrote: > Given all the near-duplicated checking of os::snprintf results, I think there > is a place for a helper function to package this up. Thank you for the suggestion. Updated to use snprintf_checked. - PR: https://git.openjdk.

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v16]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v15]

On Mon, 28 Nov 2022 07:48:23 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v15]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v14]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v12]

On Tue, 22 Nov 2022 08:02:51 GMT, Kim Barrett wrote: > Given all the near-duplicated checking of os::snprintf results, I think there > is a place for a helper function to package this up. Maybe something like > > ``` > // in class os > // Performs snprintf and asserts the result is non-negative

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v13]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v12]

On Fri, 18 Nov 2022 19:25:32 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Mon, 21 Nov 2022 06:14:44 GMT, Xue-Lei Andrew Fan wrote: >> Please don't add uses of `jio_snprintf` or `::snprintf` to hotspot. Use >> `os::snprintf`. >> >> Regarding `jio_snprintf`, see https://bugs.openjdk.org/browse/JDK-8198918. >> Regarding `os::snprintf` and `os::vsnprintf`, see >> htt

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Sun, 13 Nov 2022 20:48:04 GMT, Kim Barrett wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that use spri

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v12]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v11]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v10]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v9]

On Fri, 18 Nov 2022 06:42:24 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v9]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v8]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Sun, 13 Nov 2022 22:55:52 GMT, Xue-Lei Andrew Fan wrote: >> Please don't add uses of `jio_snprintf` or `::snprintf` to hotspot. Use >> `os::snprintf`. >> >> Regarding `jio_snprintf`, see https://bugs.openjdk.org/browse/JDK-8198918. >> Regarding `os::snprintf` and `os::vsnprintf`, see >> htt

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Wed, 16 Nov 2022 09:06:22 GMT, Thomas Stuefe wrote: >> Updated to use the result from `os::snprtinf` in the new commit. > >> A result of -1 only occurs for an encoding error. An encoding error is only >> possible with multi-byte / wide characters. (See the definition of "encoding >> error" i

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v7]

On Wed, 16 Nov 2022 07:03:12 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v7]

On Wed, 16 Nov 2022 07:03:12 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Wed, 16 Nov 2022 05:45:34 GMT, Xue-Lei Andrew Fan wrote: >> A result of -1 only occurs for an encoding error. An encoding error is only >> possible with multi-byte / wide characters. (See the definition of "encoding >> error" in C99 7.19.3/14.) We don't use those, so there won't be any encod

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Wed, 16 Nov 2022 06:43:29 GMT, Xue-Lei Andrew Fan wrote: >> src/hotspot/share/utilities/utf8.cpp line 521: >> >>> 519: } else { >>> 520: if (p + 6 >= end) break; // string is truncated >>> 521: os::snprintf(p, 7, "\\u%04x", c); >> >> This should be 6, or? We have 6 chara

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Tue, 15 Nov 2022 05:52:18 GMT, Thomas Stuefe wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> delete swp file > > src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 226: > >> 224: char buf[512]; >> 225:

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Wed, 16 Nov 2022 04:55:17 GMT, Kim Barrett wrote: >> The problem with using the return value of os::snprintf() is that we need to >> handle the -1 case to prevent the position from running backward. Might be >> better to use stringStream instead, which should handle the -1 case >> transpare

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Tue, 15 Nov 2022 07:04:38 GMT, Kim Barrett wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> delete swp file > > src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 226: > >> 224: char buf[512]; >> 225:

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v4]

On Mon, 14 Nov 2022 16:53:07 GMT, Lutz Schmidt wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> include missing os head file > > src/hotspot/share/adlc/output_c.cpp line 536: > >> 534: int printed = snpri

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v7]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Tue, 15 Nov 2022 08:31:10 GMT, Thomas Stuefe wrote: >> src/hotspot/os/bsd/attachListener_bsd.cpp line 294: >> >>> 292: (atoi(buf) != ATTACH_PROTOCOL_VER)) { >>> 293: char msg[32]; >>> 294: os::snprintf(msg, sizeof(msg), "%d\n", >>> ATTACH_ERROR_BADVERSIO

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Mon, 14 Nov 2022 19:44:17 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v4]

On Mon, 14 Nov 2022 05:32:20 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Tue, 15 Nov 2022 07:13:49 GMT, Kim Barrett wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> delete swp file > > src/hotspot/os/bsd/attachListener_bsd.cpp line 294: > >> 292: (atoi(buf) != ATT

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Mon, 14 Nov 2022 19:44:17 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

On Mon, 14 Nov 2022 19:44:17 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v4]

On Mon, 14 Nov 2022 10:21:07 GMT, Thomas Stuefe wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> include missing os head file > > src/hotspot/share/adlc/output_c.cpp line 2570: > >> 2568: int idx = inst.o

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v5]

On Mon, 14 Nov 2022 19:05:16 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v5]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v4]

On Mon, 14 Nov 2022 05:32:20 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v4]

On Mon, 14 Nov 2022 05:32:20 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Sun, 13 Nov 2022 22:55:52 GMT, Xue-Lei Andrew Fan wrote: > Please don't add uses of `jio_snprintf` or `::snprintf` to hotspot. Use > `os::snprintf`. I did not know this was our policy now. Sorry for giving the wrong advice. Maybe we should add this to the hotspot style guide since I'm proba

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v4]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v2]

On Mon, 14 Nov 2022 01:51:32 GMT, David Holmes wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - use os::snprintf for desktop update >> - use os::snprintf > > src/java.desktop/macosx/native/libjsound/PLATFOR

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v3]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v2]

On Sun, 13 Nov 2022 22:55:30 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Sun, 13 Nov 2022 20:48:04 GMT, Kim Barrett wrote: > Please don't add uses of `jio_snprintf` or `::snprintf` to hotspot. Use > `os::snprintf`. Updated to use os::snprintf, except the files under adlc where the os::snptintf definition is not included. The use of snprintf could be cleaned up

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v2]

> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Fri, 11 Nov 2022 22:41:19 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use spri

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Sun, 13 Nov 2022 08:25:57 GMT, Xue-Lei Andrew Fan wrote: > > could you use `jio_snprintf` instead (see include/jvm_io.h)? That is what > > we usually do for snprintf. jio_snprintf hides platform particularities wrt > > snprintf. > > Good to know that. Thank you! > > While I was doing the r

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Sun, 13 Nov 2022 07:50:43 GMT, Thomas Stuefe wrote: > could you use `jio_snprintf` instead (see include/jvm_io.h)? That is what we > usually do for snprintf. jio_snprintf hides platform particularities wrt > snprintf. > Good to know that. Thank you! While I was doing the replacement from

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

On Fri, 11 Nov 2022 22:41:19 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use spri

RFR: 8296812: sprintf is deprecated in Xcode 14

Hi, May I have this update reviewed? The sprintf is deprecated in Xcode 14 because of security concerns, and the use of it causing building failure. The build could pass if warnings are disabled for codes that use sprintf method. For the long run, the sprintf could be replaced with snprintf.