Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Xue-Lei Andrew Fan
On Wed, 7 Dec 2022 08:46:45 GMT, Thomas Stuefe wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment for snprintf_checked > > src/hotspot/share/adlc/output_c.cpp line 46: > >> 44: va_end(args); >> 45:

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Xue-Lei Andrew Fan
On Wed, 7 Dec 2022 16:00:04 GMT, Laurent Bourgès wrote: >> src/hotspot/os/bsd/attachListener_bsd.cpp line 260: >> >>> 258: // name ("load", "datadump", ...), and is an argument >>> 259: int expected_str_count = 2 + AttachOperation::arg_count_max; >>> 260: const int max_len = (ver_str_len

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Laurent Bourgès
On Wed, 7 Dec 2022 08:35:52 GMT, Thomas Stuefe wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment for snprintf_checked > > src/hotspot/os/bsd/attachListener_bsd.cpp line 260: > >> 258: // name

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Michael Hall
> On Dec 7, 2022, at 3:41 AM, Thomas Stuefe wrote: > > am surprised this even builds. It builds for me… * Toolchain: clang (clang/LLVM from Xcode 14.1) With the exception of these errors in cmstypes.c

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Thomas Stuefe
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Laurent Bourgès
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Xue-Lei Andrew Fan
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-06 Thread Yichen Yan
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-11-29 Thread Xue-Lei Andrew Fan
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-11-28 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be