> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is returned as Button string the Button size is incorrectly
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is returned as Button string the Button size is incorrectly
On Tue, 10 Jan 2023 17:54:35 GMT, Tejesh R wrote:
> > However, I'm still inclined to closing this bug as _Not an Issue_ because
> > you, as the developer, have to explicitly set the text for the Approve
> > button if you use the customer dialog — it's _custom_ after all.
Here I meant doing not
On Tue, 10 Jan 2023 05:18:52 GMT, Tejesh R wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` is r
On Tue, 10 Jan 2023 17:30:27 GMT, Tejesh R wrote:
> Yeah, initially had thought of doing this, but to keep the default text open
> for future changes and to maintain the default for CUSTOM Type separately I
> added additional properties and members. If using the OPEN type properties is
> fine
On Tue, 10 Jan 2023 05:18:52 GMT, Tejesh R wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` is r
On Tue, 10 Jan 2023 05:18:52 GMT, Tejesh R wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` is r
On Tue, 10 Jan 2023 14:11:50 GMT, Tejesh R wrote:
> > I suggest handling the missing text for the Approve button if a custom
> > dialog is used with adding a `JFileChooser` instance as component by
> > falling back to the `Open` type.
>
> I didn't get this point ? Can you please tell me what d
On Tue, 10 Jan 2023 13:13:25 GMT, Alexey Ivanov wrote:
> I suggest handling the missing text for the Approve button if a custom dialog
> is used with adding a `JFileChooser` instance as component by falling back to
> the `Open` type.
I didn't get this point ? Can you please tell me what does "
On Tue, 10 Jan 2023 04:50:08 GMT, Tejesh R wrote:
> > Taking the above into account,
> > [JDK-8299522](https://bugs.openjdk.org/browse/JDK-8299522) is **Not an
> > Issue**.
>
> @aivanov-jdk Agree to your point. But I added the default text and tooltip as
> a fallback text which is already in
On Mon, 9 Jan 2023 17:47:41 GMT, Damon Nguyen wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 93:
>
>> 91:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is returned as Button string the Button size is incorrectly
On Mon, 9 Jan 2023 18:49:23 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
>> line 413:
>>
>>> 411: helpButtonText =
>>> UIManager.getString("FileChooser.helpButtonText",l);
>>> 412: directoryOpenButtonText =
>>> UI
On Mon, 9 Jan 2023 10:24:49 GMT, Tejesh R wrote:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is return
On Mon, 9 Jan 2023 18:59:52 GMT, Alexey Ivanov wrote:
>
> If the programmer uses `CUSTOM_DIALOG`, they are responsible for setting the
> text and, if required, tooltip for the approve button, which is implied by
> the required `approveButtonText` parameter to
> [JFileChooser.showDialog](ht
On Mon, 9 Jan 2023 10:24:49 GMT, Tejesh R wrote:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is return
On Mon, 9 Jan 2023 17:28:36 GMT, Damon Nguyen wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` i
On Mon, 9 Jan 2023 10:24:49 GMT, Tejesh R wrote:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is return
FileChooser Open/Approve button size is shown incorrectly when no Approve
button text is set in `CUSTOM_DIALOG` type. Reason being that no default
Approve Button text is returned during Dialog Type Property change. Since
`null` is returned as Button string the Button size is incorrectly shown. T
19 matches
Mail list logo
