On Mon, 6 Feb 2023 03:31:15 GMT, Julian Waters wrote:
>> I don't know. I'm quite sure I was using the full command in `cmd.exe` after
>> calling some `vcvars64.bat`. I added the `` character because it's a little
>> long to be recorded here. I don't really care which separator is used. You
>>
On Sun, 5 Feb 2023 17:26:29 GMT, Weijun Wang wrote:
>> I've just tried copying and pasting the command with ^ instead of \ and cmd
>> doesn't seem to be correctly reading the compile command either even with ^,
>> is there something I'm missing here?
>
> I don't know. I'm quite sure I was
On Sun, 5 Feb 2023 15:55:29 GMT, Julian Waters wrote:
>> I used to have Visual Studio compilers available in my Cygwin environment.
>> Now I don't, I just point the `configure` script to the batch file which
>> configures the environment.
>>
>> If this command is supposed to be run in
On Sat, 4 Feb 2023 17:23:04 GMT, Alexey Ivanov wrote:
>> I have no objection to the code change. Or maybe you can change it to the
>> windows line extension character `^`.
>>
>> I was using this command for quick recompiling while writing this code, and
>> it's in a `cmd.exe` window launched
On Sat, 4 Feb 2023 13:36:54 GMT, Weijun Wang wrote:
>> I did think about that too when I first saw it, but the command this is
>> often run from is the Windows CMD, which does not accept `` to escape to the
>> next line. MSYS bash does not have the required environment set up outside
>> of
On Sat, 4 Feb 2023 07:42:37 GMT, Julian Waters wrote:
>> src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 31:
>>
>>> 29: // This library can be built directly with the following command:
>>> 30: // cl -I %OPENJDK%\src\java.security.jgss\share\native\libj2gss\
>>> sspi.cpp
On Fri, 3 Feb 2023 19:32:52 GMT, Alexey Ivanov wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Fri, 3 Feb 2023 15:18:27 GMT, Julian Waters wrote:
>> Several comments are technically broken in Windows code, this change cleans
>> up the broken comments that managed to slip past reviewers during Integration
>
> Julian Waters has updated the pull request with a new target base due to a
>
> Several comments are technically broken in Windows code, this change cleans
> up the broken comments that managed to slip past reviewers during Integration
Julian Waters has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the
