On Wed, 8 Feb 2023 08:23:59 GMT, Julian Waters wrote:
>>> Alright here you go :) https://bugs.openjdk.org/browse/JDK-8301994
>>
>> Thank you, @TheShermanTanker.
>>
>> Do you still want to keep the changes?
>> If it's not too critical, I would rather prefer you revert the changes to
>>
On Tue, 7 Feb 2023 19:19:27 GMT, Alexey Ivanov wrote:
>> Alright here you go :) https://bugs.openjdk.org/browse/JDK-8301994
>
>> Alright here you go :) https://bugs.openjdk.org/browse/JDK-8301994
>
> Thank you, @TheShermanTanker.
>
> Do you still want to keep the changes?
> If it's not too
On Tue, 7 Feb 2023 17:08:07 GMT, Julian Waters wrote:
> Alright here you go :) https://bugs.openjdk.org/browse/JDK-8301994
Thank you, @TheShermanTanker.
Do you still want to keep the changes?
If it's not too critical, I would rather prefer you revert the changes to
`awt_List.cpp`.
On Tue, 7 Feb 2023 16:11:59 GMT, Alexey Ivanov wrote:
>> Perhaps, but I'll leave that to the discretion of the client libs group. Are
>> the new changes fine with you though?
>
> I'd rather remove the offending commented out code than change its formatting.
>
> Could you submit a bug, please,
On Tue, 7 Feb 2023 15:57:35 GMT, Julian Waters wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_List.cpp line 183:
>>
>>> 181: // SetWindowPos(hList, 0, 0, 0, w, h, flags);
>>> 182: // }
>>> 183: //
>>
>> Maybe it's time to remove this commented out code? It's been commented
On Tue, 7 Feb 2023 15:14:20 GMT, Alexey Ivanov wrote:
>> Julian Waters has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - D3DVertexCacher.cpp
>> - awt_List.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_List.cpp line 183:
>
On Tue, 7 Feb 2023 01:17:18 GMT, Julian Waters wrote:
>> Several comments are technically broken in Windows code, this change cleans
>> up the broken comments that managed to slip past reviewers during Integration
>
> Julian Waters has updated the pull request incrementally with two additional
> Several comments are technically broken in Windows code, this change cleans
> up the broken comments that managed to slip past reviewers during Integration
Julian Waters has updated the pull request incrementally with two additional
commits since the last revision:
- D3DVertexCacher.cpp
-
