Re: RFR: 8302173: Button border overlaps with button icon on macOS system LaF [v3]

2023-02-21 Thread Harshitha Onkar
On Tue, 21 Feb 2023 23:10:44 GMT, SWinxy wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add instanceof check > > src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 344: > >> 342: final V

Re: RFR: 8302173: Button border overlaps with button icon on macOS system LaF [v3]

2023-02-21 Thread Damon Nguyen
On Tue, 21 Feb 2023 23:10:44 GMT, SWinxy wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add instanceof check > > src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 344: > >> 342: final V

Re: RFR: 8302173: Button border overlaps with button icon on macOS system LaF [v3]

2023-02-21 Thread SWinxy
On Tue, 14 Feb 2023 23:02:16 GMT, Damon Nguyen wrote: >> Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in >> a JButton in Aqua L&F. The new issue comes from having text inside the HTML >> as the button's text. If an icon is used, this icon exceeds the bounds of >> th

Re: RFR: 8302173: Button border overlaps with button icon on macOS system LaF [v3]

2023-02-21 Thread Damon Nguyen
On Tue, 14 Feb 2023 02:29:16 GMT, Harshitha Onkar wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add instanceof check > > Changes requested by honkar (Committer). @honkar-jdk Could you take another look at the ch

Re: RFR: 8302173: Button border overlaps with button icon on macOS system LaF [v3]

2023-02-14 Thread Damon Nguyen
On Tue, 14 Feb 2023 22:08:26 GMT, Harshitha Onkar wrote: >> Yes, I tested with these combinations: >> Icon with HTML image >> > src="https://user-images.githubusercontent.com/96267980/218855067-68186106-77df-4c2b-81d7-2cd24e28f4bb.png";> >> >> Icon with HTML text >> > src="https://user-images.gi

Re: RFR: 8302173: Button border overlaps with button icon on macOS system LaF [v3]

2023-02-14 Thread Damon Nguyen
> Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in a > JButton in Aqua L&F. The new issue comes from having text inside the HTML as > the button's text. If an icon is used, this icon exceeds the bounds of the > button and overlaps the border. > > Added additional logi