Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-28 Thread Damon Nguyen
On Thu, 27 Apr 2023 10:44:27 GMT, Andrey Turbanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove extra folders > > test/jdk/java/awt/dnd/SkipDropCompleteTest/SkipDropCompleteTest.java line 56: > >> 54:

Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-28 Thread Damon Nguyen
On Thu, 27 Apr 2023 07:19:01 GMT, Sergey Bylokhov wrote: >> meaning you are suggesting they need to be volatile ? > > or changed to be used on the same thread, in this case EDT. It seems > different tests use different approaches. I made this var volatile and put the frame blocks in the EDT. Sh

Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-27 Thread Andrey Turbanov
On Tue, 25 Apr 2023 23:16:33 GMT, Damon Nguyen wrote: >> This PR open sources a few more AWT DnD related tests > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove extra folders test/jdk/java/awt/dnd/SkipDropCompleteTest

Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-27 Thread Sergey Bylokhov
On Wed, 26 Apr 2023 17:57:47 GMT, Phil Race wrote: >> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 114: >> >>> 112: } >>> 113: >>> 114: if (incorrectActionDetected) { >> >> incorrectActionDetected is set on one thread an used on another, same for >> "frame" in othe

Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-26 Thread Phil Race
On Wed, 26 Apr 2023 17:37:34 GMT, Sergey Bylokhov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove extra folders > > test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 114: > >> 112: } >> 113:

Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-26 Thread Sergey Bylokhov
On Tue, 25 Apr 2023 23:16:33 GMT, Damon Nguyen wrote: >> This PR open sources a few more AWT DnD related tests > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove extra folders test/jdk/java/awt/dnd/RejectDragDropAction

Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-25 Thread Damon Nguyen
> This PR open sources a few more AWT DnD related tests Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Remove extra folders - Changes: - all: https://git.openjdk.org/jdk/pull/13653/files - new: https://git.openjdk.o