Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-19 Thread Alexey Ivanov
On Mon, 19 Feb 2024 06:02:10 GMT, Prasanta Sadhukhan wrote: > guess you can do "\integrate" for us to "sponsor" Or rather, @vtstydev, issue the [`/integrate`](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate) command to integrate the fix. Someone wil

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-18 Thread Prasanta Sadhukhan
On Fri, 9 Feb 2024 09:47:25 GMT, vtstydev wrote: >>> > Revert the changes to the test which limit the pages printed out. >>> > The test MUST print all orientations and MUST always print both opaque >>> > and alpha >>> > 95% of the point of this test is to ensure consistency across all cases >>>

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-09 Thread vtstydev
On Fri, 9 Feb 2024 03:21:44 GMT, Phil Race wrote: >> vtstydev has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove trailing whitespace >> - Done requested fixes 2 > >> > Revert the changes to the test which limit the pages printed o

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-08 Thread Phil Race
On Thu, 1 Feb 2024 11:32:17 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has u

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-04 Thread vtstydev
On Sun, 4 Feb 2024 13:34:47 GMT, Phil Race wrote: > Revert the changes to the test which limit the pages printed out. > The test MUST print all orientations and MUST always print both opaque and > alpha > 95% of the point of this test is to ensure consistency across all cases and > if it doesn'

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-04 Thread Phil Race
On Thu, 1 Feb 2024 11:32:17 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has u

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-01 Thread Prasanta Sadhukhan
On Thu, 1 Feb 2024 11:32:17 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has u

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-01 Thread vtstydev
> More correct way to take in consideration nonzero PHYSICALOFFSETX, > PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows > platform under certain conditions real device prints shifted image on paper. vtstydev has updated the pull request incrementally with two additional