Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v12]

2024-02-13 Thread Alexey Ivanov
On Tue, 13 Feb 2024 06:50:29 GMT, vtstydev wrote: >> test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java >> line 155: >> >>> 153: } >>> 154: >>> 155: class CustomPrintable implements Printable { >> >> I suggest making `CustomPrintable` a static nested class in >> `Alph

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v12]

2024-02-12 Thread vtstydev
On Mon, 12 Feb 2024 20:02:21 GMT, Alexey Ivanov wrote: >> vtstydev has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Done requested fixes 4 > > test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java > line 155: > >> 1

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v12]

2024-02-12 Thread Alexey Ivanov
On Mon, 12 Feb 2024 12:33:30 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v12]

2024-02-12 Thread vtstydev
> More correct way to take in consideration nonzero PHYSICALOFFSETX, > PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows > platform under certain conditions real device prints shifted image on paper. vtstydev has updated the pull request incrementally with one additional