Re: [jdk21] RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-23 Thread Phil Race
On Fri, 23 Jun 2023 18:45:41 GMT, Alexander Zuev wrote: > Backport of a regression fix for JDK-8309733 > > Changes applied cleanly. Marked as reviewed by prr (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/59#pullrequestreview-1495745120

[jdk21] RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-23 Thread Alexander Zuev
Backport of a regression fix for JDK-8309733 Changes applied cleanly. - Commit messages: - Backport d1d2b55ce0b950e07f6e3761983f73fd58079627 Changes: https://git.openjdk.org/jdk21/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=59&range=00 Issue: https://bugs.op

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-23 Thread Artem Semenov
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Sergey Bylokhov
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Alexey Ivanov
On Thu, 22 Jun 2023 18:45:27 GMT, Alexander Zuev wrote: >> src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java line 185: >> >>> 183: // Do send check box state changes to native side >>> 184: if (thisRole == AccessibleRole.CHECK_BOX) { >>> 18

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Alexander Zuev
On Thu, 22 Jun 2023 18:46:51 GMT, Artem Semenov wrote: > Is it possible to add a regression test on these components? to > `test/jdk/java/awt/a11y` Not within this regression type fix unless i find a way to write an automatic regression test which i don't see a way of. As of creating a compreh

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Phil Race
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Artem Semenov
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Sergey Bylokhov
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Alexander Zuev
On Thu, 22 Jun 2023 18:44:00 GMT, Sergey Bylokhov wrote: >> Only pass value changed event to the native accessibility peer when the >> value is actually changed. While at fixing it for RadioButton also fixing it >> for checkbox and toggle button so there is no need to re-visit this file >> lat

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Abhishek Kumar
On Thu, 22 Jun 2023 15:41:47 GMT, Alexander Zuev wrote: > > Should VO announce radiobutton's position also? > > That is beyond the scope of this bug but overall i would look at the native > applications with the same type of controls. If native controls do not > demonstrate the same behavior t

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Abhishek Kumar
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Alexander Zuev
On Thu, 22 Jun 2023 05:27:43 GMT, Abhishek Kumar wrote: > Should VO announce radiobutton's position also? That is beyond the scope of this bug but overall i would look at the native applications with the same type of controls. If native controls do not demonstrate the same behavior then i woul

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-21 Thread Abhishek Kumar
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-21 Thread Alexander Zuev
Only pass value changed event to the native accessibility peer when the value is actually changed. While at fixing it for RadioButton also fixing it for checkbox and toggle button so there is no need to re-visit this file later. Also updating the copyright year. - Commit messages: