Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-03 Thread Alexey Ivanov
On Tue, 3 Oct 2023 18:08:16 GMT, Harshitha Onkar wrote: >> Sure, I just added it. Previously when I initially worked on this test, >> setAutoWaitForIdle had a weird interaction with how the test was setup. >> Since the test used a delay of 50ms between each of the movements when >> dragging th

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-03 Thread Harshitha Onkar
On Tue, 3 Oct 2023 17:59:19 GMT, Damon Nguyen wrote: >> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 90: >> >>> 88: Robot robot = new Robot(); >>> 89: robot.waitForIdle(); >>> 90: robot.delay(DELAY_TIME); >> >> Does adding `robot.autoWaitForIdle(t

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-03 Thread Damon Nguyen
On Mon, 2 Oct 2023 23:56:12 GMT, Harshitha Onkar wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove pack for explicit size > > test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 90: > >> 88:

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-02 Thread Harshitha Onkar
On Mon, 2 Oct 2023 23:51:04 GMT, Damon Nguyen wrote: >> This test intermittently fails by timeout. Increasing the timeout alone >> doesn't solve the failure as it still fails in about 400 runs. Adding >> another delay and reducing the delay amount to 1000ms. Now, the test passes >> after 2 set

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-02 Thread Damon Nguyen
On Mon, 2 Oct 2023 23:33:44 GMT, Harshitha Onkar wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove pack for explicit size > > test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 84: > >> 82:

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-02 Thread Damon Nguyen
> This test intermittently fails by timeout. Increasing the timeout alone > doesn't solve the failure as it still fails in about 400 runs. Adding another > delay and reducing the delay amount to 1000ms. Now, the test passes after 2 > sets of 500 repeats on all OS's without a timeout. Damon Nguy