On Tue, 19 Sep 2023 16:10:38 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JToolBar/bug4368050.java line 48:
>>
>>> 46: ObjectInputStream ois = new ObjectInputStream(bais)) {
>>> 47: ois.readObject();
>>> 48: }
>>
>> Better to close the stream ob
On Tue, 19 Sep 2023 16:30:07 GMT, Harshitha Onkar wrote:
>>> Better to close the stream objects in finally block in case of Exception.
>>>
>>> ```
>>> finally {
>>> if (oos != null) {
>>> oos.close();
>>> }
>>> if (ois != null) {
>>> ois.close();
>>> }
>>>
On Mon, 18 Sep 2023 19:30:46 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4368050/bug4368050.java
>> javax/swing/JToolBar/4465534/bug4465534.java
>> javax/swing/JToolBar/4700351/bug4700351.java
>> javax/swing/JToolTip/4107843/bug4107843.java
>> java
On Tue, 19 Sep 2023 16:02:21 GMT, Harshitha Onkar wrote:
> Better to close the stream objects in finally block in case of Exception.
>
> ```
> finally {
> if (oos != null) {
> oos.close();
> }
> if (ois != null) {
> ois.close();
> }
> }
> ```
No, *it's
On Mon, 18 Sep 2023 19:30:46 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4368050/bug4368050.java
>> javax/swing/JToolBar/4465534/bug4465534.java
>> javax/swing/JToolBar/4700351/bug4700351.java
>> javax/swing/JToolTip/4107843/bug4107843.java
>> java
On Mon, 18 Sep 2023 19:30:46 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4368050/bug4368050.java
>> javax/swing/JToolBar/4465534/bug4465534.java
>> javax/swing/JToolBar/4700351/bug4700351.java
>> javax/swing/JToolTip/4107843/bug4107843.java
>> java
> These are the tests being converted:
>
> javax/swing/JToolBar/4368050/bug4368050.java
> javax/swing/JToolBar/4465534/bug4465534.java
> javax/swing/JToolBar/4700351/bug4700351.java
> javax/swing/JToolTip/4107843/bug4107843.java
> javax/swing/JTree/4161685/bug4161685.java
Damon Nguyen has updated
On Mon, 18 Sep 2023 13:58:18 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments updates
>
> test/jdk/javax/swing/JToolBar/bug4368050.java line 47:
>
>> 45: oos.writeObject(t
