On Thu, 5 Oct 2023 15:29:15 GMT, Prasanta Sadhukhan
wrote:
> If you concede they are different, then what change you want me to do? If you
> say center is safer and then still use menuLocation coordinate which is
> obtained via getLocationScreen, it's confusing..
I see no big difference in dr
On Thu, 5 Oct 2023 15:23:57 GMT, Alexey Ivanov wrote:
> Yes, they're somewhat different
If you concede they are different, then what change you want me to do? If you
say center is safer and then still use menuLocation coordinate which is
obtained via getLocationScreen, it's confusing..
I think
On Thu, 5 Oct 2023 15:15:24 GMT, Prasanta Sadhukhan
wrote:
> But 1st case uses center coordinates via Util.getCenterPoint whereas 2nd case
> uses getLocationOnScreen+10 so it's not exactly the same.
Yes, they're somewhat different. Yet the centre is safer (what if
`getLocationOnScreen+10` is
On Thu, 5 Oct 2023 14:51:47 GMT, Alexey Ivanov wrote:
>> I guess menu is closed before mouse is dragged, no?
>>
>> The sequence as I see is
>> 1. Move mouse to center of menu
>> 2. Press to open the menu
>> 3. Move mouse to center of menuitem which is greyed
>> 4. Press mouse button
>> 5. Check
On Wed, 4 Oct 2023 13:58:59 GMT, Prasanta Sadhukhan
wrote:
> So, I think pt 7 "close menu" is happening before pt 8 "drag mouse"Yes,
> "point" is being reused but I guess it's ok
It is okay, yet I think it would be clearer and cleaner if the flow was like
this:
1. Complete the first case
On Wed, 4 Oct 2023 11:01:09 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> jcheck
>
> test/jdk/javax/swing/JMenuItem/4654927/bug4654927.java line 1:
>
>> 1: /*
>
> I looked at the test c
On Wed, 4 Oct 2023 09:30:55 GMT, Prasanta Sadhukhan
wrote:
>> Test was run without waiting for UI to be made visible leading to
>> IllegalComponentStateException.
>> Used robot.delay consistent with other headful tests to made the test wait
>> after UI is created and shown.
>>
>> Test passed
> Test was run without waiting for UI to be made visible leading to
> IllegalComponentStateException.
> Used robot.delay consistent with other headful tests to made the test wait
> after UI is created and shown.
>
> Test passed in several iterations in all platforms. Link in JBS
Prasanta Sadhuk
