Re: RFR: 8316017: Refactor timeout handler in PassFailJFrame [v2]

2023-10-24 Thread Phil Race
On Tue, 24 Oct 2023 11:04:52 GMT, Alexey Ivanov wrote: >> Refactored timeout handling in PassFailJFrame: >> >> 1. Managing the timer and formatting the time left is inside >> `TimeoutHandler` class. >> 2. The class handles timer events and updates the label accordingly. >> >> This is implement

Re: RFR: 8316017: Refactor timeout handler in PassFailJFrame [v2]

2023-10-24 Thread Alexey Ivanov
On Tue, 19 Sep 2023 18:35:12 GMT, Phil Race wrote: >> Alexey Ivanov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refactor failure reason >> >> Ensure the failure reason doesn't change after it's set. >> Removed 'failed' and 'ti

Re: RFR: 8316017: Refactor timeout handler in PassFailJFrame [v2]

2023-10-24 Thread Alexey Ivanov
> Refactored timeout handling in PassFailJFrame: > > 1. Managing the timer and formatting the time left is inside `TimeoutHandler` > class. > 2. The class handles timer events and updates the label accordingly. > > This is implemented on top of #15665. Alexey Ivanov has updated the pull request