On Thu, 28 Sep 2023 17:10:39 GMT, Phil Race wrote:
>>> Since this isn't a test for applet I think we should keep it for now
>>
>> What do you mean?
>>
>> All the test does is it verifies the `installComponents` method is
>> accessible in a subclass of `BasicMenuItemUI`. The
>> [`installCompon
On Thu, 28 Sep 2023 16:00:15 GMT, Alexey Ivanov wrote:
>> Since this isn't a test for applet I think we should keep it for now
>
>> Since this isn't a test for applet I think we should keep it for now
>
> What do you mean?
>
> All the test does is it verifies the `installComponents` method is a
On Thu, 28 Sep 2023 15:39:27 GMT, Alisen Chung wrote:
> Since this isn't a test for applet I think we should keep it for now
What do you mean?
All the test does is it verifies the `installComponents` method is accessible
in a subclass of `BasicMenuItemUI`. The
[`installComponents`](https://do
On Mon, 25 Sep 2023 22:00:33 GMT, Alisen Chung wrote:
>> test/jdk/javax/swing/BasicMenuUI/bug4244616.java line 67:
>>
>>> 65: action.actionPerformed(ev);
>>> 66: } catch (Exception ignored) {
>>> 67: }
>>
>> Are exceptions thrown here?
>
> Yea
On Mon, 25 Sep 2023 11:45:24 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - updated tests based on feedback
>> - updated tests
>
> test/jdk/javax/swing/BasicMenuItemUI/bug4239714.java line 27
On Mon, 25 Sep 2023 11:57:18 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - updated tests based on feedback
>> - updated tests
>
> test/jdk/javax/swing/BasicMenuUI/bug4244616.java line 67:
>
On Sun, 24 Sep 2023 06:12:17 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15 javax/swing/plaf/meta
On Sun, 24 Sep 2023 06:12:17 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15 javax/swing/plaf/meta
> Opening closed tests:
> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
> 15 javax/swing/plaf/metal/4306431/bug4306431.java
Alisen Chung has updated the pull