Re: RFR: 8316324: Opensource five miscellaneous Swing tests [v3]

2024-03-25 Thread Alexander Zuev
> Clean up and opensource five tests. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Make test fail if it can not instantiate required look and feel; - Changes: - all: https://git.openjdk.org/jdk/pull/18443/files

Re: RFR: 8316324: Opensource five miscellaneous Swing tests [v2]

2024-03-25 Thread Alexander Zuev
On Mon, 25 Mar 2024 21:24:13 GMT, Phil Race wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removing image file as not needed, generating ImageIcon instead; >> Moved test file from the dedicated folder siince i

Re: RFR: 8316324: Opensource five miscellaneous Swing tests [v2]

2024-03-25 Thread Phil Race
On Mon, 25 Mar 2024 16:24:10 GMT, Alexander Zuev wrote: >> Clean up and opensource five tests. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Removing image file as not needed, generating ImageIcon instead; > Moved tes

Re: RFR: 8316324: Opensource five miscellaneous Swing tests [v2]

2024-03-25 Thread Alexander Zuev
> Clean up and opensource five tests. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Removing image file as not needed, generating ImageIcon instead; Moved test file from the dedicated folder siince it is no longer needed; Remo

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-25 Thread Alexander Zuev
On Sat, 23 Mar 2024 23:59:42 GMT, Phil Race wrote: >> It is just a gif file filled with yellow color created specifically for that >> test. It was not provided by the test submitter or anything like that - it >> was just created in the graphics editor. There's no copyright issue with it. > > ye

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-25 Thread Alexander Zuev
On Sun, 24 Mar 2024 00:00:25 GMT, Phil Race wrote: >> test/jdk/javax/swing/InputVerifier/bug4774166.java line 229: >> >>> 227: public void cleanupGUI() { >>> 228: if (testframe != null) { >>> 229: testframe.setVisible(false); >> >> `testframe.setVisible(false);` is requi

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-23 Thread Phil Race
On Fri, 22 Mar 2024 08:54:07 GMT, Tejesh R wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/InputVerifier/bug4774166.java line 229: > >> 227: public void cleanupGUI() { >> 228: if (testframe != null) { >> 229: testframe.setVisible(false); > > `testf

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-23 Thread Phil Race
On Fri, 22 Mar 2024 21:39:43 GMT, Alexander Zuev wrote: >> test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42: >> >>> 40: public class bug4385611 { >>> 41: static JButton bt1, bt2; >>> 42: static final ImageIcon icon32x32 = new >>> ImageIcon(bug4385611.class.getResource("red.g

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Alexander Zuev
On Fri, 22 Mar 2024 09:01:01 GMT, Tejesh R wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/InputVerifier/bug4774166.java line 144: > >> 142: public void performTest() throws InterruptedException, >> InvocationTargetException { >> 143: robot.setAutoDelay(100);

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Alexander Zuev
On Fri, 22 Mar 2024 07:02:05 GMT, Prasanta Sadhukhan wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42: > >> 40: public class bug4385611 { >> 41: static JButton bt1, bt2; >> 42: static final ImageIcon icon32x32 = new >> Image

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Alexander Zuev
On Fri, 22 Mar 2024 09:04:28 GMT, Tejesh R wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/InputVerifier/bug4774166.java line 165: > >> 163: robot.hitKey(KeyEvent.VK_M); >> 164: robot.hitKey(KeyEvent.VK_N); >> 165: robot.hitKey(KeyEvent.VK_O); > >

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Alexander Zuev
On Fri, 22 Mar 2024 06:57:12 GMT, Prasanta Sadhukhan wrote: >> Clean up and opensource five tests. > > test/jdk/javax/swing/InputVerifier/bug4774166.java line 44: > >> 42: * @summary InputVerifier should be called after a window loses and then >> regains focus >> 43: * @library /javax/swing/

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Tejesh R
On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev wrote: > Clean up and opensource five tests. test/jdk/javax/swing/InputVerifier/bug4774166.java line 144: > 142: public void performTest() throws InterruptedException, > InvocationTargetException { > 143: robot.setAutoDelay(100); > 1

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev wrote: > Clean up and opensource five tests. test/jdk/javax/swing/InputVerifier/bug4774166.java line 44: > 42: * @summary InputVerifier should be called after a window loses and then > regains focus > 43: * @library /javax/swing/regtesthelpers

RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-21 Thread Alexander Zuev
Clean up and opensource five tests. - Commit messages: - 8316324: Opensource five miscellaneous Swing tests Changes: https://git.openjdk.org/jdk/pull/18443/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18443&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316324