On Fri, 19 Jan 2024 01:52:47 GMT, Sergey Bylokhov wrote:
>> Note that it does not fail with NPE but instead this code trigger the bug:
>>
>> AppContext eventContext = targetToAppContext(event.getSource());
>> if (eventContext != null && !eventContext.equals(appContext)) {
>>
On Fri, 19 Jan 2024 01:43:48 GMT, Sergey Bylokhov wrote:
>> Somehow we have null passed in.
>> So something looked up appcontext and got null.
>> Likely because some other code removed the app context from a map or
>> similar.
>> First step is to find exactly where that happened, then we can st
On Thu, 18 Jan 2024 23:06:07 GMT, Phil Race wrote:
>> I think the context became null because the component doesn't exist anymore
>
> Somehow we have null passed in.
> So something looked up appcontext and got null.
> Likely because some other code removed the app context from a map or similar.
On Thu, 18 Jan 2024 16:38:37 GMT, Alisen Chung wrote:
>> then it should be checked what is going on there. The context should not
>> just become null for the existing component.
>
> I think the context became null because the component doesn't exist anymore
Somehow we have null passed in.
So so
On Thu, 18 Jan 2024 08:47:40 GMT, Sergey Bylokhov wrote:
>> if the SunToolkit.executeOnEventHandlerThread is removed, then the test
>> doesn't throw an exception, but the icon doesn't disappear (test fails)
>
> then it should be checked what is going on there. The context should not just
> beco
On Wed, 17 Jan 2024 21:56:25 GMT, Alisen Chung wrote:
>> I'm checking to see if removing executeOnEventHandlerThread solves the
>> issue. In this test the source of the appcontext (trayIcon) is deleted via
>> an actionPerformed listener, so probably the deletion of the trayIcon comes
>> first
On Wed, 17 Jan 2024 18:49:06 GMT, Alisen Chung wrote:
>> So what is the root cause of null context here?
>
> I'm checking to see if removing executeOnEventHandlerThread solves the issue.
> In this test the source of the appcontext (trayIcon) is deleted via an
> actionPerformed listener, so prob
On Wed, 17 Jan 2024 00:26:20 GMT, Sergey Bylokhov wrote:
>> Or maybe it is a lack of synchronization?
>
> So what is the root cause of null context here?
I'm checking to see if removing executeOnEventHandlerThread solves the issue.
In this test the source of the appcontext (trayIcon) is deleted
On Mon, 15 Jan 2024 11:33:31 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/sun/awt/SunToolkit.java line 450:
>>
>>> 448: if (appContext == null) {
>>> 449: return;
>>> 450: }
>>
>> I think we should check why the appcontext is null here, the event com
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
On Mon, 15 Jan 2024 11:27:43 GMT, Sergey Bylokhov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> used jtreg.SkippedException, updated copyright years
>
> src/java.desktop/share/classes/sun/awt/SunToolkit.java line
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
> the TrayIcon was already removed by the test, causing an error. The fix is to
> make SunToolkit skip posting the event if appContext is null. The test is
> also updated to remove applet usage and use PassFailJFrame in
15 matches
Mail list logo
