Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v5]

2023-11-16 Thread Alexey Ivanov
On Thu, 16 Nov 2023 11:25:47 GMT, Prasanta Sadhukhan wrote: >> CSSBackgroundImage.equals() is implemented > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Remove this reference Marked as reviewed by aivanov (Reviewer

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v5]

2023-11-16 Thread Prasanta Sadhukhan
> CSSBackgroundImage.equals() is implemented Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Remove this reference - Changes: - all: https://git.openjdk.org/jdk/pull/16613/files - new: https://git.openjdk.org/j

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v4]

2023-11-16 Thread Alexey Ivanov
On Thu, 16 Nov 2023 10:51:48 GMT, Prasanta Sadhukhan wrote: >> CSSBackgroundImage.equals() is implemented > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Use Objects.hashCode src/java.desktop/share/classes/javax/swi

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v4]

2023-11-16 Thread Prasanta Sadhukhan
> CSSBackgroundImage.equals() is implemented Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Use Objects.hashCode - Changes: - all: https://git.openjdk.org/jdk/pull/16613/files - new: https://git.openjdk.org/jd

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v3]

2023-11-16 Thread Andrey Turbanov
On Thu, 16 Nov 2023 07:04:43 GMT, Prasanta Sadhukhan wrote: >> CSSBackgroundImage.equals() is implemented > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Use Objects.hashCode and add bugid Use Objects.hashCode witho

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v3]

2023-11-16 Thread Andrey Turbanov
On Fri, 10 Nov 2023 21:12:16 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use Objects.hashCode and add bugid > > src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2971

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v3]

2023-11-15 Thread Prasanta Sadhukhan
> CSSBackgroundImage.equals() is implemented Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Use Objects.hashCode and add bugid - Changes: - all: https://git.openjdk.org/jdk/pull/16613/files - new: https://git.

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v2]

2023-11-15 Thread Prasanta Sadhukhan
> CSSBackgroundImage.equals() is implemented Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Use Objects.hashCode and add bugid - Changes: - all: https://git.openjdk.org/jdk/pull/16613/files - new: https://git.

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals

2023-11-15 Thread Alexey Ivanov
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan wrote: > CSSBackgroundImage.equals() is implemented [My recent comment](https://github.com/openjdk/jdk/pull/16613#discussion_r1392808012) removed my approval. It's *approved* after the following is addressed: > Please add 8318113 to the @

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals

2023-11-15 Thread Phil Race
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan wrote: > CSSBackgroundImage.equals() is implemented Marked as reviewed by prr (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16613#pullrequestreview-1732749217

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals

2023-11-14 Thread Alexey Ivanov
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan wrote: > CSSBackgroundImage.equals() is implemented Changes requested by aivanov (Reviewer). test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java line 1: > 1: /* Please add 8318113 to the `@bug` tag in the test. -

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals

2023-11-14 Thread Tejesh R
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan wrote: > CSSBackgroundImage.equals() is implemented Looks good to me. - Marked as reviewed by tr (Committer). PR Review: https://git.openjdk.org/jdk/pull/16613#pullrequestreview-1729386160

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals

2023-11-10 Thread Sergey Bylokhov
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan wrote: > CSSBackgroundImage.equals() is implemented src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2971: > 2969: @Override > 2970: public int hashCode() { > 2971: return (this.svalue != null) ?

Re: RFR: 8318113: CSS.BackgroundImage doesn't implement equals

2023-11-10 Thread Alexey Ivanov
On Fri, 10 Nov 2023 13:50:27 GMT, Prasanta Sadhukhan wrote: > CSSBackgroundImage.equals() is implemented Marked as reviewed by aivanov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16613#pullrequestreview-1725016640

RFR: 8318113: CSS.BackgroundImage doesn't implement equals

2023-11-10 Thread Prasanta Sadhukhan
CSSBackgroundImage.equals() is implemented - Commit messages: - 8318113: CSS.BackgroundImage doesn't implement equals - 8318113: CSS.BackgroundImage doesn't implement equals Changes: https://git.openjdk.org/jdk/pull/16613/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1661