Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-02-07 Thread Alexey Ivanov
On Thu, 1 Feb 2024 00:39:16 GMT, Alisen Chung wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Suggestions integrated > > test/jdk/java/awt/print/PageFormat/PageSetupDialog.java line 225: > >> 223:

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-31 Thread Renjith Kannath Pariyangad
On Wed, 31 Jan 2024 23:07:45 GMT, Harshitha Onkar wrote: >> Updating the size impacting layouts, its visible in my system. > > With the present frame size and layout settings, Set Paper" and "Print" > options are not visible. > >

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-31 Thread Alisen Chung
On Tue, 30 Jan 2024 06:30:00 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-31 Thread Harshitha Onkar
On Tue, 30 Jan 2024 07:58:12 GMT, Renjith Kannath Pariyangad wrote: >> test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 263: >> >>> 261: ta.setEditable(false); >>> 262: add(ta); >>> 263: setSize(500, 650); >> >> Set paper and Print options are not

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-31 Thread Alisen Chung
On Tue, 30 Jan 2024 06:30:00 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-30 Thread Renjith Kannath Pariyangad
On Tue, 30 Jan 2024 00:14:05 GMT, Harshitha Onkar wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Suggestions integrated > > test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-29 Thread Renjith Kannath Pariyangad
On Tue, 30 Jan 2024 06:30:00 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-29 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-24 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has