Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-09 Thread Renjith Kannath Pariyangad
On Wed, 7 Feb 2024 17:48:41 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disposed g2D object and similar test parm into one line > > test/jdk/java/awt/print/PrinterJob/PrintAllFo

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-07 Thread Alexey Ivanov
On Thu, 1 Feb 2024 10:06:21 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know y

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-07 Thread Alexey Ivanov
On Wed, 7 Feb 2024 16:38:11 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disposed g2D object and similar test parm into one line > > test/jdk/java/awt/print/PageFormat/PageSetupD

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-07 Thread Alexey Ivanov
On Tue, 30 Jan 2024 00:23:04 GMT, Harshitha Onkar wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disposed g2D object and similar test parm into one line > > test/jdk/java/awt/print/PrinterJob/raster/

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-06 Thread Alisen Chung
On Thu, 1 Feb 2024 10:06:21 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know y

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-02 Thread Harshitha Onkar
On Thu, 1 Feb 2024 10:06:21 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know y

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-01 Thread Renjith Kannath Pariyangad
On Wed, 31 Jan 2024 23:07:45 GMT, Harshitha Onkar wrote: >> Updating the size impacting layouts, its visible in my system. > > With the present frame size and layout settings, Set Paper" and "Print" > options are not visible. > > ![image](https://github.com/openjdk/jdk/assets/95945681/b1bf6d28

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-01 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has upda

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-01-28 Thread Renjith Kannath Pariyangad
On Fri, 26 Jan 2024 00:27:45 GMT, Harshitha Onkar wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Fixed whitespace errors > > @Renjithkannath There are many test changes in a single PR, it would be >

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-01-25 Thread Harshitha Onkar
On Thu, 25 Jan 2024 05:37:40 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-01-24 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has upd