Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v6]

2024-03-05 Thread Alexey Ivanov
On Tue, 13 Feb 2024 14:01:40 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Fixed compiler error > > test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 53: > >> 51:

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v6]

2024-02-13 Thread Renjith Kannath Pariyangad
On Tue, 13 Feb 2024 10:43:38 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Fixed compiler error > > test/jdk/java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java line 74: > >>

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v6]

2024-02-13 Thread Alexey Ivanov
On Tue, 13 Feb 2024 08:46:19 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v6]

2024-02-13 Thread Alexey Ivanov
On Thu, 1 Feb 2024 10:08:27 GMT, Renjith Kannath Pariyangad wrote: >> With the present frame size and layout settings, Set Paper" and "Print" >> options are not visible. >> >> ![image](https://github.com/openjdk/jdk/assets/95945681/b1bf6d28-858e-4b32-aec4-dd24dfdf7dc0) > > Yes, Mac have an is

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v6]

2024-02-13 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has upda