On Mon, 19 Aug 2024 16:27:21 GMT, Damon Nguyen wrote:
>> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
>> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
>> This fix was to make other L&Fs in line with the Aqua fix found in
>> [JDK-80158
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854).
>
> Howev
On Fri, 16 Aug 2024 18:56:25 GMT, Damon Nguyen wrote:
>> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
>> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
>> This fix was to make other L&Fs in line with the Aqua fix found in
>> [JDK-80158
On Fri, 16 Aug 2024 18:53:22 GMT, Damon Nguyen wrote:
>> I agree, adding a note at both places looks clearer. The additional note in
>> MetalLookAndFeel.java as above gives a quick lookup.
>
> That does sound best. Added the notes to both areas as suggested. I still
> don't know how to not make
On Fri, 16 Aug 2024 16:44:17 GMT, Harshitha Onkar wrote:
>>> I moved it to `BasicLookAndFeel.java` since that's where the values are
>>> specifically defined.
>>
>> Perhaps, we need a note in *both files*.
>>
>> In `MetalLookAndFeel.java` to refer to `BasicLookAndFeel` where the margin
>> is
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854).
>
> Howev
On Fri, 16 Aug 2024 16:16:07 GMT, Alexey Ivanov wrote:
>> Agreed. This is what I found as well. Had a bit of trouble figuring out how
>> to phrase the note since the comment was meant to differentiate Metal from
>> the other default installed LAFs.
>>
>> I moved it to `BasicLookAndFeel.java` s
On Thu, 15 Aug 2024 19:12:32 GMT, Damon Nguyen wrote:
> I moved it to `BasicLookAndFeel.java` since that's where the values are
> specifically defined.
Perhaps, we need a note in *both files*.
In `MetalLookAndFeel.java` to refer to `BasicLookAndFeel` where the margin is
defined, similar to wh
On Thu, 15 Aug 2024 18:32:08 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move note
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java
> line 810:
>
>> 808:
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854).
>
> Howev
On Thu, 15 Aug 2024 18:06:49 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java
>> line 810:
>>
>>> 808: "released SPACE", "released"
>>> 809: }),
>>> 810: // margin is (2, 14, 2, 14) which is vastl
On Tue, 6 Aug 2024 23:12:44 GMT, Damon Nguyen wrote:
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](h
On Wed, 14 Aug 2024 20:43:35 GMT, Alisen Chung wrote:
>> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
>> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
>> This fix was to make other L&Fs in line with the Aqua fix found in
>> [JDK-80158
On Tue, 6 Aug 2024 23:12:44 GMT, Damon Nguyen wrote:
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](h
On Mon, 12 Aug 2024 09:53:10 GMT, Alexey Ivanov wrote:
> I still don't quite understand where the margin comes from.
>
> A comment, like the one you have currently, which points to where the values
> come from would be good.
>
> Adding anything to public javadoc requires a CSR. Not sure if you
On Tue, 6 Aug 2024 23:12:44 GMT, Damon Nguyen wrote:
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](h
On Tue, 6 Aug 2024 23:12:44 GMT, Damon Nguyen wrote:
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](h
On Fri, 9 Aug 2024 22:35:06 GMT, Damon Nguyen wrote:
> I found the values to be set in `BasicLookAndFeel.java` which explains why
> other custom L&F's are also affected. Moving the doc to there and changing
> this back to a public doc change can be done instead. Otherwise, I can leave
> it as
On Tue, 6 Aug 2024 23:12:44 GMT, Damon Nguyen wrote:
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](h
On Tue, 6 Aug 2024 23:12:44 GMT, Damon Nguyen wrote:
> Previously in [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> there was a fix for JButtons with HTML content alignment for non-MacOS L&Fs.
> This fix was to make other L&Fs in line with the Aqua fix found in
> [JDK-8015854](h
20 matches
Mail list logo
