On Wed, 10 Apr 2024 11:23:22 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JTable/JTableScrollPrintTest.java line 45:
>>
>>> 43: * @test
>>> 44: * @key headful
>>> 45: * @bug 8210807 8322140
>>
>> Suggestion:
>>
>> You may update the test with `PassFailJFrame.builder()`.
>>
>> I guess `Grap
On Wed, 10 Apr 2024 08:56:08 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> s
On Wed, 10 Apr 2024 09:05:49 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> s
On Wed, 10 Apr 2024 10:27:03 GMT, Abhishek Kumar wrote:
>> I'm sure whether a new Graphics2D object will be created or reference will
>> be passed, just vaguely remember a conversation regarding disposing it and
>> suggested not to dispose since a reference will be passed on. So not sure
>> sh
On Wed, 10 Apr 2024 09:59:19 GMT, Tejesh R wrote:
>> Since you are creating it locally, I guess you can dispose it.
>
> I'm sure whether a new Graphics2D object will be created or reference will be
> passed, just vaguely remember a conversation regarding disposing it and
> suggested not to disp
On Wed, 10 Apr 2024 09:51:05 GMT, Abhishek Kumar wrote:
>> I'm not sure whether we have to dispose it here at this context.
>
> Since you are creating it locally, I guess you can dispose it.
I'm sure whether a new Graphics2D object will be created or reference will be
passed, just vaguely remem
On Wed, 10 Apr 2024 09:32:42 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/sun/print/PathGraphics.java line 1155:
>>
>>> 1153:
>>> resolutionImage.getHeight(null),
>>> 1154:
On Wed, 10 Apr 2024 08:57:00 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> s
On Wed, 10 Apr 2024 04:43:29 GMT, Tejesh R wrote:
>> Fix suggested in bug
>> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720)
>> had a regression in Nimbus L&F yet it resolved the issue in other L&F. The
>> better approach would be to handle `MultiResol
On Wed, 10 Apr 2024 04:43:29 GMT, Tejesh R wrote:
>> Fix suggested in bug
>> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720)
>> had a regression in Nimbus L&F yet it resolved the issue in other L&F. The
>> better approach would be to handle `MultiResol
> Fix suggested in bug
> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720)
> had a regression in Nimbus L&F yet it resolved the issue in other L&F. The
> better approach would be to handle `MultiResolutionImages `in `PathGraphics`
> class `getBufferedImag
11 matches
Mail list logo
