On Thu, 15 Feb 2024 17:46:08 GMT, Alexander Zuev wrote:
>> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
>> overflow.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - added space to a catc
On Thu, 15 Feb 2024 17:43:03 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 90:
>>
>>> 88: if (accessible instanceof AccessibleComponent) {
>>> 89: try {
>>> 90: AccessibleComponent component =
>>> (Acc
On Wed, 14 Feb 2024 20:06:54 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved frame disposal to the EDT
>
> test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 90:
>
>> 88:
On Wed, 14 Feb 2024 20:01:01 GMT, Alexey Ivanov wrote:
>> done.
>
> This is not thread-safe, the condition `if (mainFrame != null)` should also
> be inside `invokeAndWait`.
>
> Maybe create a method to use method reference: `invokeAndWait(me::dispose)`?
> In this case, `mainFrame` could be mad
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
Alexander Zuev has updated the pull request incrementally with two additional
commits since the last revision:
- added space to a catch clause
- Moved frame disposal to the separate method to make it mo
On Wed, 14 Feb 2024 19:47:30 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 56:
>>
>>> 54: SwingUtilities.invokeAndWait(me::test);
>>> 55: } finally {
>>> 56: if (mainFrame != null) {
>>
>> should be disposed on EDT.
>
On Wed, 14 Feb 2024 19:50:34 GMT, Alexander Zuev wrote:
>> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
>> overflow.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Moved frame disposal to
On Wed, 14 Feb 2024 06:58:15 GMT, Abhishek Kumar wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing some coding style related issues
>
> test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 56:
>
>>
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Moved frame disposal to the EDT
-
Changes:
- all: https://git.openjdk.org/jd
On Wed, 14 Feb 2024 05:29:21 GMT, Alexander Zuev wrote:
>> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
>> overflow.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixing some coding styl
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixing some coding style related issues
-
Changes:
- all: https://git.openjd
On Mon, 12 Feb 2024 20:57:38 GMT, Alexander Zuev wrote:
>> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
>> overflow.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Handling of InvalidComp
On Fri, 9 Feb 2024 04:26:48 GMT, Sergey Bylokhov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Handling of InvalidComponentStateException added
>>
>> Added regression test
>
> src/java.desktop/share/classe
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Handling of InvalidComponentStateException added
Added regression test
-
On Tue, 6 Feb 2024 20:13:01 GMT, Alexander Zuev wrote:
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 2340:
> 2338:
> 2339: public Point getLocationOnScreen() {
> 2340:
On Thu, 8 Feb 2024 15:09:10 GMT, Alexey Ivanov wrote:
> wonder if it's appropriate that location or dimension become `null`. I would
> expect these properties always return a non-`null` value, maybe in
> exceptional conditions.
>
> If a tab becomes hidden because of the overflow, it is appropr
On Tue, 6 Feb 2024 20:13:01 GMT, Alexander Zuev wrote:
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
I wonder if it's appropriate that location or dimension become `null`. I would
expect these properties always return a non-`null` value, maybe in ex
On Tue, 6 Feb 2024 20:13:01 GMT, Alexander Zuev wrote:
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
Verified the fix on MacOS 13.6.3. Looks good to me.
-
Marked as reviewed by abhiscxk (Committer).
PR Review: https://git.openjdk.org/j
On Tue, 6 Feb 2024 20:13:01 GMT, Alexander Zuev wrote:
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
LGTM
-
Marked as reviewed by asemenov (Committer).
PR Review: https://git.openjdk.org/jdk/pull/17736#pullrequestreview-1867250733
Add null check for the Aqua LnF situation when tab is hidden die to the tabs
overflow.
-
Commit messages:
- 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus
is moved on the JTabbedPane
Changes: https://git.openjdk.org/jdk/pull/17736/files
Webrev: https:
20 matches
Mail list logo
