Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v3]

2024-02-15 Thread Alexander Zuev
On Wed, 14 Feb 2024 20:01:01 GMT, Alexey Ivanov wrote: >> done. > > This is not thread-safe, the condition `if (mainFrame != null)` should also > be inside `invokeAndWait`. > > Maybe create a method to use method reference: `invokeAndWait(me::dispose)`? > In this case, `mainFrame` could be mad

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v3]

2024-02-14 Thread Alexey Ivanov
On Wed, 14 Feb 2024 19:47:30 GMT, Alexander Zuev wrote: >> test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 56: >> >>> 54: SwingUtilities.invokeAndWait(me::test); >>> 55: } finally { >>> 56: if (mainFrame != null) { >> >> should be disposed on EDT. >

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v3]

2024-02-14 Thread Alexander Zuev
On Wed, 14 Feb 2024 06:58:15 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing some coding style related issues > > test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 56: > >>

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v3]

2024-02-13 Thread Abhishek Kumar
On Wed, 14 Feb 2024 05:29:21 GMT, Alexander Zuev wrote: >> Add null check for the Aqua LnF situation when tab is hidden die to the tabs >> overflow. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Fixing some coding styl

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane [v3]

2024-02-13 Thread Alexander Zuev
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs > overflow. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Fixing some coding style related issues - Changes: - all: https://git.openjd