Re: RFR: 8322545: Declare newInsets as static in ThemeReader.cpp [v2]

2024-01-08 Thread Alexey Ivanov
On Mon, 8 Jan 2024 19:48:36 GMT, Rajat Mahajan wrote: >> Since newInsets() function is a helper function used in ThemeReader.cpp only >> , this change declares it as static. > > Rajat Mahajan has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8322545: Declare newInsets as static in ThemeReader.cpp [v2]

2024-01-08 Thread Rajat Mahajan
> 8322545: Declare newInsets as static in ThemeReader.cpp Rajat Mahajan has updated the pull request incrementally with one additional commit since the last revision: Update copyright year 2024 - Changes: - all: https://git.openjdk.org/jdk/pull/17310/files - new: https://git.

Re: RFR: 8322545: Declare newInsets as static in ThemeReader.cpp

2024-01-08 Thread Sergey Bylokhov
On Mon, 8 Jan 2024 18:45:05 GMT, Rajat Mahajan wrote: > 8322545: Declare newInsets as static in ThemeReader.cpp Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17310#pullrequestreview-1809890460

Re: RFR: 8322545: Declare newInsets as static in ThemeReader.cpp

2024-01-08 Thread Alexey Ivanov
On Mon, 8 Jan 2024 18:45:05 GMT, Rajat Mahajan wrote: > 8322545: Declare newInsets as static in ThemeReader.cpp Marked as reviewed by aivanov (Reviewer). src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 1: > 1: /* Update the copyright year to 2024. - PR Review

RFR: 8322545: Declare newInsets as static in ThemeReader.cpp

2024-01-08 Thread Rajat Mahajan
8322545: Declare newInsets as static in ThemeReader.cpp - Commit messages: - 8322545: Declare newInsets as static in ThemeReader.cpp Changes: https://git.openjdk.org/jdk/pull/17310/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17310&range=00 Issue: https://bugs.openjdk.o