Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-06 Thread Alexey Ivanov
On Wed, 6 Mar 2024 10:43:16 GMT, Tejesh R wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Replace synchronized invalidateFileCache with synchronized block inside >> - Declare DoChangeContents constructor priva

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-06 Thread Tejesh R
On Tue, 5 Mar 2024 11:07:13 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-05 Thread Alexey Ivanov
On Tue, 5 Mar 2024 11:07:13 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-05 Thread Alexey Ivanov
On Tue, 5 Mar 2024 09:24:52 GMT, Andrey Turbanov wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Replace synchronized invalidateFileCache with synchronized block inside >> - Declare DoChangeContents constructo

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-05 Thread Alexey Ivanov
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between these > two operations, another thread or even several t

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-05 Thread Alexey Ivanov
On Tue, 5 Mar 2024 00:48:13 GMT, Sergey Bylokhov wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Replace synchronized invalidateFileCache with synchronized block inside >> - Declare DoChangeContents constructo