Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v3]

2024-03-01 Thread Abhishek Kumar
On Thu, 29 Feb 2024 07:48:09 GMT, Abhishek Kumar wrote: >> Menu mnemonic doesn't toggle between show and hide state when F10 is >> pressed. Behavior is not similar to windows native application. Fix is to >> ensure that menu mnemonic state toggles between show and hide. >> >> Can be verified w

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v3]

2024-02-29 Thread Abhishek Kumar
On Thu, 29 Feb 2024 11:02:35 GMT, Alexey Ivanov wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comment update > > src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuBarUI.java >

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v3]

2024-02-29 Thread Alexey Ivanov
On Thu, 29 Feb 2024 07:48:09 GMT, Abhishek Kumar wrote: >> Menu mnemonic doesn't toggle between show and hide state when F10 is >> pressed. Behavior is not similar to windows native application. Fix is to >> ensure that menu mnemonic state toggles between show and hide. >> >> Can be verified w

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v3]

2024-02-28 Thread Abhishek Kumar
> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. > Behavior is not similar to windows native application. Fix is to ensure that > menu mnemonic state toggles between show and hide. > > Can be verified with SwingSet2 application. > CI tests are green with the fix.