Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]

2024-03-23 Thread Phil Race
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote: >> Convert test to a main method based; >> Move test to an apropriate location; >> Remove old files; > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Remove .html fro

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]

2024-03-21 Thread Alisen Chung
On Thu, 21 Mar 2024 18:15:23 GMT, Alisen Chung wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove .html from the @test clause > > test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 142: > >> 140:

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]

2024-03-21 Thread Alisen Chung
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote: >> Convert test to a main method based; >> Move test to an apropriate location; >> Remove old files; > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Remove .html fro

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]

2024-03-21 Thread Alisen Chung
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote: >> Convert test to a main method based; >> Move test to an apropriate location; >> Remove old files; > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Remove .html fro

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

2024-03-20 Thread Alexander Zuev
On Wed, 20 Mar 2024 17:21:13 GMT, Damon Nguyen wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved test metadate closer to the class definition; >> Made variables local; >> Made test skip execution on an un

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v4]

2024-03-20 Thread Alexander Zuev
> Convert test to a main method based; > Move test to an apropriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Remove .html from the @test clause - Changes: - all: https://git.openj

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

2024-03-20 Thread Alexander Zuev
On Wed, 20 Mar 2024 17:23:36 GMT, Damon Nguyen wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved test metadate closer to the class definition; >> Made variables local; >> Made test skip execution on an un

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

2024-03-20 Thread Damon Nguyen
On Wed, 20 Mar 2024 16:07:50 GMT, Alexander Zuev wrote: >> Convert test to a main method based; >> Move test to an apropriate location; >> Remove old files; > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Moved test metad

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

2024-03-20 Thread Alexander Zuev
> Convert test to a main method based; > Move test to an apropriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Moved test metadate closer to the class definition; Made variables local; Made tes

Re: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v2]

2024-03-19 Thread Alexander Zuev
> Convert test to a main method based; > Move test to an apropriate location; > Remove old files; Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Adding library and build clauses - Changes: - all: https://git.openjdk

RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main

2024-03-18 Thread Alexander Zuev
Convert test to a main method based; Move test to an apropriate location; Remove old files; - Commit messages: - 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main Changes: https://git.openjdk.org/jdk/pull/18363/files Webrev: https://webrevs.openjdk.org/?repo=j