Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-17 Thread Alexey Ivanov
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Abhishek Kumar
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Abhishek Kumar
On Fri, 12 Apr 2024 05:15:53 GMT, Renjith Kannath Pariyangad wrote: > Its working for me, please make sure you have configured pdf printer as your > default printer. In this test there is no option to select printer. Yeah... default was set to physical printer which is currently inaccessible.

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Renjith Kannath Pariyangad
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Abhishek Kumar
On Fri, 12 Apr 2024 04:30:34 GMT, Renjith Kannath Pariyangad wrote: > Yes this will work on Print to pdf, I don't think physical printer is must. I am getting this dialog message "Printer status is not available at this time." - PR Comment: https://git.openjdk.org/jdk/pull/18624#i

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Renjith Kannath Pariyangad
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-10 Thread Abhishek Kumar
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-08 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the test with PassFailJFrame along with printer availability > check. Please review and let me know your suggestions. > > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementally with two additional commits since the last revision: - U

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame

2024-04-07 Thread Abhishek Kumar
On Thu, 4 Apr 2024 12:07:46 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > I have updated the test with PassFailJFrame along with printer availability > check. Please review and let me know your suggestions. > > Renjith. test/jdk/java/awt/print/PageFormat/Orient.java line 38: >

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame

2024-04-07 Thread Tejesh R
On Thu, 4 Apr 2024 12:07:46 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > I have updated the test with PassFailJFrame along with printer availability > check. Please review and let me know your suggestions. > > Renjith. Did you test it for other L&F also? test/jdk/java/awt/prin

RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame

2024-04-04 Thread Renjith Kannath Pariyangad
Hi Reviewers, I have updated the test with PassFailJFrame along with printer availability check. Please review and let me know your suggestions. Renjith. - Commit messages: - JDK-8329322:Convert PageFormat/Orient.java to use PassFailJFrame Changes: https://git.openjdk.org/jdk/pul