Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-24 Thread Alexander Zuev
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-24 Thread Prasanta Sadhukhan
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-24 Thread Artem Semenov
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-23 Thread Alexander Zuev
On Thu, 23 May 2024 12:45:31 GMT, Artem Semenov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replaced NULL with nil in OutlineAccessibility - functionally it has no >> effect but it is more uiform and accordi

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-23 Thread Artem Semenov
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-23 Thread Abhishek Kumar
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-23 Thread Abhishek Kumar
On Thu, 23 May 2024 08:08:17 GMT, Alexander Zuev wrote: >> Ok. >> Is it possible to add a test to verify this behavior? > > The test would be manual and it is hard to even describe what is the result > of the test should look or sound like since we do not provide any string > messages, VoiceOve

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-23 Thread Alexander Zuev
On Wed, 22 May 2024 11:17:26 GMT, Abhishek Kumar wrote: >> In multilevel trees when someone in the parent's path is collapsed the >> treeCollapsed event will be delivered to that node. We can either invalidate >> all leaf nodes caches (which is costly) or mark that exact node's cache as >> inv

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-22 Thread Abhishek Kumar
On Wed, 22 May 2024 06:40:02 GMT, Alexander Zuev wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/OutlineAccessibility.m >> line 98: >> >>> 96: - (BOOL)isCacheValid >>> 97: { >>> 98: if (rowCacheValid && [[self parent] >>> respondsToSelector:NSSelectorFromString(@"isCacheVali

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-21 Thread Alexander Zuev
On Tue, 21 May 2024 08:47:04 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Remove unused import; > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/OutlineAccessibility.m > line 70:

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-21 Thread Alexander Zuev
> Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer needed; Alexander Zuev has updated the pull request incrementall

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-21 Thread Abhishek Kumar
On Mon, 20 May 2024 08:20:11 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-20 Thread Artem Semenov
On Mon, 20 May 2024 08:20:11 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v2]

2024-05-20 Thread Alexander Zuev
On Mon, 20 May 2024 07:16:49 GMT, Artem Semenov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Removed the unused import in CAccessibility.java >> - Rolled back changes to the CommonComponentAccessibility an

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-20 Thread Alexander Zuev
> Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer needed; Alexander Zuev has updated the pull request incrementall

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-20 Thread Alexander Zuev
On Fri, 17 May 2024 10:00:08 GMT, Abhishek Kumar wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Remove unused import; > > src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java line 39: > >> 37:

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v2]

2024-05-20 Thread Artem Semenov
On Mon, 20 May 2024 05:17:23 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v2]

2024-05-19 Thread Abhishek Kumar
On Mon, 20 May 2024 05:17:23 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer nee

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v2]

2024-05-19 Thread Alexander Zuev
> Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer needed; Alexander Zuev has updated the pull request incrementall

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-18 Thread Alexander Zuev
On Sat, 18 May 2024 18:39:42 GMT, Artem Semenov wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer need

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-18 Thread Artem Semenov
On Thu, 16 May 2024 01:28:37 GMT, Alexander Zuev wrote: > Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer needed;

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-16 Thread Victor Dyakov
On Thu, 16 May 2024 01:28:37 GMT, Alexander Zuev wrote: > Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer needed;

RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-15 Thread Alexander Zuev
Caching children and selected children of the thee on the native level; Caching all children of a specific parent in CAccessibility to enhance recursive children selection algorithm; Removing fix for JDK-8317771 as no longer needed; - Commit messages: - 8329667: [macos] Issue with J