On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Mon, 22 Apr 2024 17:38:59 GMT, Jonathan Gibbons wrote:
> The document [How to Write Doc Comments for the Javadoc
> Tool](https://www.oracle.com/uk/technical-resources/articles/java/javadoc-tool.html)
> is depressingly obsolete, as indicated by this text towards the end:
I know. Yet there's
On Fri, 19 Apr 2024 19:29:31 GMT, Alexey Ivanov wrote:
> > We do not have an overall style guide. The conventional wisdom for editing
> > any existing file is to follow the style in that file, if such a style can
> > be discerned.
>
> That's what I do.
>
> I saw either style used in JDK. Yet
On Fri, 19 Apr 2024 20:38:05 GMT, Naoto Sato wrote:
> OK, fair enough. Approving for the `icu` part
Thank you.
-
PR Comment: https://git.openjdk.org/jdk/pull/18846#issuecomment-2067280359
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Fri, 19 Apr 2024 19:47:20 GMT, Naoto Sato wrote:
> Unless it is absolutely necessary, I would not fix comments in
> `jdk.internal.icu` sources, as they are in the upstream code, and would like
> to minimize the merging effort.
@naotoj Given the policy and strong desire to compile
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Fri, 19 Apr 2024 19:18:31 GMT, Jonathan Gibbons wrote:
> We do not have an overall style guide. The conventional wisdom for editing
> any existing file is to follow the style in that file, if such a style can be
> discerned.
That's what I do.
I saw either style used in JDK. Yet I didn't
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Fri, 19 Apr 2024 11:32:55 GMT, Pavel Rappo wrote:
> This comment is not a review. I simply use the opportunity provided by this
> PR to suggest that we stop making new `/** ... */` and separately fix old
> jtreg comments like this:
>
> ```
> /**
> * @test TestSmallHeap
> * @bug 8067438
On Fri, 19 Apr 2024 10:49:11 GMT, Alexey Ivanov wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update
>> src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java
>>
>> Fix
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or import statements
> * Misplaced doc comments after the
On Fri, 19 Apr 2024 10:44:27 GMT, Alexey Ivanov wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before package
On Fri, 19 Apr 2024 10:53:11 GMT, Alexey Ivanov wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before package
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
Please review a set of updates to clean up use of `/**` comments in the
vicinity of declarations.
There are various categories of update:
* "Box comments" beginning with `/**`
* Misplaced doc comments before package or import statements
* Misplaced doc comments after the annotations for a
24 matches
Mail list logo