Re: RFR: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms

2024-06-11 Thread Abhishek Kumar
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan wrote: > TestUngrab.java was added for > [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the > test can be run for all platforms as the behaviour is common for all > CI run job link in JBS.. There are few unused imp

Re: RFR: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms

2024-06-11 Thread Abhishek Kumar
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan wrote: > TestUngrab.java was added for > [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix. I think that this test was added for [JDK-8325435](https://bugs.openjdk.org/browse/JDK-8325435) that you recently integrated. Pl

Re: RFR: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms

2024-06-11 Thread Tejesh R
On Wed, 12 Jun 2024 04:17:02 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JMenu/TestUngrab.java line 28: >> >>> 26: /* >>> 27: * @test >>> 28: * @bug 8267374 >> >> Should the current bug id be updated here? > > No, we only put the product ids in the tag and this is test-only fix O

Re: RFR: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms

2024-06-11 Thread Tejesh R
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan wrote: > TestUngrab.java was added for > [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the > test can be run for all platforms as the behaviour is common for all > CI run job link in JBS.. Marked as reviewed by tr

Re: RFR: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms

2024-06-11 Thread Prasanta Sadhukhan
On Wed, 12 Jun 2024 04:12:13 GMT, Tejesh R wrote: >> TestUngrab.java was added for >> [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the >> test can be run for all platforms as the behaviour is common for all >> CI run job link in JBS.. > > test/jdk/javax/swing/JMenu/T

Re: RFR: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms

2024-06-11 Thread Tejesh R
On Tue, 11 Jun 2024 06:05:02 GMT, Prasanta Sadhukhan wrote: > TestUngrab.java was added for > [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the > test can be run for all platforms as the behaviour is common for all > CI run job link in JBS.. test/jdk/javax/swing/JMe

RFR: 8333940: Ensure javax/swing/TestUngrab.java run on all platforms

2024-06-10 Thread Prasanta Sadhukhan
TestUngrab.java was added for [JDK-8267374](https://bugs.openjdk.org/browse/JDK-8267374) macos fix but the test can be run for all platforms as the behaviour is common for all CI run job link in JBS.. - Commit messages: - Test-fix Changes: https://git.openjdk.org/jdk/pull/19644/fi