Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

2024-07-10 Thread Sergey Bylokhov
On Tue, 25 Jun 2024 22:03:38 GMT, Phil Race wrote: > or if the layout code is executed first then I'd expect to see zero machinery > init cost here. It will be good to check thi.s So we'll use it freely, assuming it won't introduce any additional overhead. - PR Comment:

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v3]

2024-07-09 Thread Andrey Turbanov
On Thu, 27 Jun 2024 18:29:55 GMT, Phil Race wrote: >> Migrate font code from jdk.internal.misc.Unsafe to using FFM. >> This reduces the coupling between the java.desktop module and the internals >> of the java.base module. >> >> The code being changed here is not particularly performance

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

2024-06-27 Thread Phil Race
On Wed, 26 Jun 2024 20:51:18 GMT, Alisen Chung wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8334495 > > src/java.desktop/share/classes/sun/font/GlyphList.java line 364: > >> 362: * a native call which

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v3]

2024-06-27 Thread Phil Race
> Migrate font code from jdk.internal.misc.Unsafe to using FFM. > This reduces the coupling between the java.desktop module and the internals > of the java.base module. > > The code being changed here is not particularly performance sensitive, and it > is not executed in the most common cases.

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

2024-06-26 Thread Alisen Chung
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote: >> Migrate font code from jdk.internal.misc.Unsafe to using FFM. >> This reduces the coupling between the java.desktop module and the internals >> of the java.base module. >> >> The code being changed here is not particularly performance

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

2024-06-25 Thread Phil Race
On Tue, 25 Jun 2024 09:22:45 GMT, Per Minborg wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8334495 > > src/java.desktop/share/classes/sun/font/StrikeCache.java line 112: > >> 110: * references a memory

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

2024-06-25 Thread Phil Race
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote: >> Migrate font code from jdk.internal.misc.Unsafe to using FFM. >> This reduces the coupling between the java.desktop module and the internals >> of the java.base module. >> >> The code being changed here is not particularly performance

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

2024-06-25 Thread Per Minborg
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote: >> Migrate font code from jdk.internal.misc.Unsafe to using FFM. >> This reduces the coupling between the java.desktop module and the internals >> of the java.base module. >> >> The code being changed here is not particularly performance

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

2024-06-24 Thread Sergey Bylokhov
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote: >> Migrate font code from jdk.internal.misc.Unsafe to using FFM. >> This reduces the coupling between the java.desktop module and the internals >> of the java.base module. >> >> The code being changed here is not particularly performance

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

2024-06-24 Thread Phil Race
> Migrate font code from jdk.internal.misc.Unsafe to using FFM. > This reduces the coupling between the java.desktop module and the internals > of the java.base module. > > The code being changed here is not particularly performance sensitive, and it > is not executed in the most common cases.

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-24 Thread Jorn Vernee
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote: > Migrate font code from jdk.internal.misc.Unsafe to using FFM. > This reduces the coupling between the java.desktop module and the internals > of the java.base module. > > The code being changed here is not particularly performance sensitive,

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-24 Thread Phil Race
On Mon, 24 Jun 2024 18:07:11 GMT, Maurizio Cimadamore wrote: >> src/java.desktop/share/classes/sun/font/StrikeCache.java line 151: >> >>> 149: >>> 150: @SuppressWarnings("restricted") >>> 151: static final float getGlyphXAdvance(long ptr) { >> >> now, I'm not an expert of this code,

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-24 Thread Maurizio Cimadamore
On Mon, 24 Jun 2024 18:04:38 GMT, Maurizio Cimadamore wrote: >> Migrate font code from jdk.internal.misc.Unsafe to using FFM. >> This reduces the coupling between the java.desktop module and the internals >> of the java.base module. >> >> The code being changed here is not particularly

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-24 Thread Maurizio Cimadamore
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote: > Migrate font code from jdk.internal.misc.Unsafe to using FFM. > This reduces the coupling between the java.desktop module and the internals > of the java.base module. > > The code being changed here is not particularly performance sensitive,

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-21 Thread Damon Nguyen
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote: > Migrate font code from jdk.internal.misc.Unsafe to using FFM. > This reduces the coupling between the java.desktop module and the internals > of the java.base module. > > The code being changed here is not particularly performance sensitive,

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-20 Thread Phil Race
On Tue, 18 Jun 2024 22:01:26 GMT, Alisen Chung wrote: > How do I test this fix? There isn't a specific test because it is code that is used internally in somewhat random cases. A number of automated tests will use it (and they do all pass) and just running a UI app will sometimes exercise this

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-19 Thread Magnus Ihse Bursie
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote: > Migrate font code from jdk.internal.misc.Unsafe to using FFM. > This reduces the coupling between the java.desktop module and the internals > of the java.base module. > > The code being changed here is not particularly performance sensitive,

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-18 Thread Alisen Chung
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote: > Migrate font code from jdk.internal.misc.Unsafe to using FFM. > This reduces the coupling between the java.desktop module and the internals > of the java.base module. > > The code being changed here is not particularly performance sensitive,

RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-18 Thread Phil Race
Migrate font code from jdk.internal.misc.Unsafe to using FFM. This reduces the coupling between the java.desktop module and the internals of the java.base module. The code being changed here is not particularly performance sensitive, and it is not executed in the most common cases. The main