Re: RFR: 8334599: Improve code from JDK-8302671 [v3]

2024-08-04 Thread Julian Waters
On Thu, 11 Jul 2024 08:41:28 GMT, Julian Waters wrote: >> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a >> memmove decay bug by rewriting a sizeof on an array to an explicit size of >> 256, but this is a bit of a band aid fix. It's come to my attention that in >> C++,

Re: RFR: 8334599: Improve code from JDK-8302671 [v3]

2024-07-22 Thread Alexey Ivanov
On Thu, 11 Jul 2024 08:41:28 GMT, Julian Waters wrote: >> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a >> memmove decay bug by rewriting a sizeof on an array to an explicit size of >> 256, but this is a bit of a band aid fix. It's come to my attention that in >> C++,

Re: RFR: 8334599: Improve code from JDK-8302671 [v3]

2024-07-17 Thread Julian Waters
On Wed, 17 Jul 2024 17:28:21 GMT, Thomas Stuefe wrote: > Okay. > > (Please don't go now and change all occurrences of `foo(pointer, size)` to > something like `foo( [&] [size] )` :-) I dislike the increased cognitive load > of this form, and prefer the classic pointer+size combo ) Even if I w

Re: RFR: 8334599: Improve code from JDK-8302671 [v3]

2024-07-17 Thread Thomas Stuefe
On Thu, 11 Jul 2024 08:41:28 GMT, Julian Waters wrote: >> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a >> memmove decay bug by rewriting a sizeof on an array to an explicit size of >> 256, but this is a bit of a band aid fix. It's come to my attention that in >> C++,

Re: RFR: 8334599: Improve code from JDK-8302671 [v3]

2024-07-14 Thread Julian Waters
On Thu, 11 Jul 2024 08:41:28 GMT, Julian Waters wrote: >> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a >> memmove decay bug by rewriting a sizeof on an array to an explicit size of >> 256, but this is a bit of a band aid fix. It's come to my attention that in >> C++,

Re: RFR: 8334599: Improve code from JDK-8302671 [v3]

2024-07-11 Thread Julian Waters
> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a > memmove decay bug by rewriting a sizeof on an array to an explicit size of > 256, but this is a bit of a band aid fix. It's come to my attention that in > C++, one can pass an array by reference, which causes sizeof to w