On Sat, 17 Aug 2024 00:55:50 GMT, Sergey Bylokhov wrote:
>> ok..fixed..
>
> Look like is not fixed yet?
Spelling mistake "Tocuh" is fixed...Do you see more?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20289#discussion_r1721137908
On Tue, 30 Jul 2024 03:16:27 GMT, Prasanta Sadhukhan
wrote:
>> I was pointing out a spelling mistake. Nothing more.
>
> ok..fixed..
Look like is not fixed yet?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20289#discussion_r1720494106
On Sun, 28 Jul 2024 23:14:03 GMT, Phil Race wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - typo
>> - copyright year
>> - L&F typo
>
> The only LAF I see that sets supportsOneTouchButtons is GTK and it
On Mon, 29 Jul 2024 17:51:28 GMT, Phil Race wrote:
>> DId you want "touch" instead of "create"?
>> I guess it should be "create" as the code does```
>>
>> /* Create the left button and add an action listener to
>> expand/collapse it. */
>> leftButton = createLeftOneTouchButton();
>
> I was point
On Mon, 29 Jul 2024 07:10:47 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
>> line 399:
>>
>>> 397: * divider is contained in changes.
>>> 398: * If a particular L&F supports
>>> SplitPane.supportsOneTocuhButtons p
On Sun, 28 Jul 2024 23:14:03 GMT, Phil Race wrote:
> The only LAF I see that sets supportsOneTouchButtons is GTK and it sets it to
> false .. so nothing anywhere sets it to true ! And in the code being updated
> "true" is passed as the default value to DefaultLookup.getBoolean
>
> So this seem
On Tue, 23 Jul 2024 08:18:07 GMT, Prasanta Sadhukhan
wrote:
>> BasicSplitPaneDivider:oneTouchExpandableChanged() spec doesn't mention that
>> it will create left/right button only if L&F supports
>> SplitPane.supportsOneTouchButtons which is now added in javadoc..
>
> Prasanta Sadhukhan has up
On Tue, 23 Jul 2024 08:18:07 GMT, Prasanta Sadhukhan
wrote:
>> BasicSplitPaneDivider:oneTouchExpandableChanged() spec doesn't mention that
>> it will create left/right button only if L&F supports
>> SplitPane.supportsOneTouchButtons which is now added in javadoc..
>
> Prasanta Sadhukhan has up
On Tue, 23 Jul 2024 08:18:07 GMT, Prasanta Sadhukhan
wrote:
>> BasicSplitPaneDivider:oneTouchExpandableChanged() spec doesn't mention that
>> it will create left/right button only if L&F supports
>> SplitPane.supportsOneTouchButtons which is now added in javadoc..
>
> Prasanta Sadhukhan has up
> BasicSplitPaneDivider:oneTouchExpandableChanged() spec doesn't mention that
> it will create left/right button only if L&F supports
> SplitPane.supportsOneTouchButtons which is now added in javadoc..
Prasanta Sadhukhan has updated the pull request incrementally with three
additional commits s
10 matches
Mail list logo
