On Fri, 23 Aug 2024 22:14:12 GMT, Jonathan Gibbons wrote:
> With my official `jtreg` hat on, I recommend always placing the `jtreg` tags
> immediately after any legal header comments and _before_ any and all of the
> source code that comprises the test.
@jonathan-gibbons Are there any disadvan
On Fri, 23 Aug 2024 22:36:51 GMT, Jonathan Gibbons wrote:
>> Moving files from one directory to another can sometimes be a bit risky,
>> especially for `javac` tests, because that implies moving the classes from
>> one unnamed package to a different unnamed package.
>>
>> Please confirm that a
On Fri, 23 Aug 2024 22:31:04 GMT, Jonathan Gibbons wrote:
>> toshiogata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert "Move jtreg tags and expand wildcard imports"
>>
>> This reverts commit 9b30df1230b7e31b42e63ae01ef154956
On Mon, 19 Aug 2024 01:28:20 GMT, toshiogata wrote:
>> Rename the tests to prevent unexpected deletion of result files when
>> `-retain` jtreg option is specified.
>> Testing: modified tests
>
> toshiogata has updated the pull request incrementally with one additional
> commit since the last re
On Mon, 19 Aug 2024 12:34:15 GMT, Alexey Ivanov wrote:
>> Thank you for pointing it out. I was not aware of the git rename issue.
>> I changed the fix to only rename files.
>
>> Thank you for pointing it out. I was not aware of the git rename issue.
>
> Even if it were not for this Git “limitati
On Mon, 19 Aug 2024 01:28:20 GMT, toshiogata wrote:
>> Rename the tests to prevent unexpected deletion of result files when
>> `-retain` jtreg option is specified.
>> Testing: modified tests
>
> toshiogata has updated the pull request incrementally with one additional
> commit since the last re
On Mon, 19 Aug 2024 01:28:20 GMT, toshiogata wrote:
>> Rename the tests to prevent unexpected deletion of result files when
>> `-retain` jtreg option is specified.
>> Testing: modified tests
>
> toshiogata has updated the pull request incrementally with one additional
> commit since the last re
On Mon, 19 Aug 2024 01:37:36 GMT, toshiogata wrote:
> Thank you for pointing it out. I was not aware of the git rename issue.
Even if it were not for this Git “limitation”, I still think additional changes
should be requested by Java Compiler team. I am not aware of their practices.
@alisenchu
On Fri, 16 Aug 2024 11:43:05 GMT, Alexey Ivanov wrote:
>> toshiogata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move jtreg tags and expand wildcard imports
>
> I suggest not to edit the files and only *rename them* as it was in the
On Fri, 16 Aug 2024 01:02:17 GMT, toshiogata wrote:
>> test/langtools/tools/javac/warnings/Serial/Serial.java line 1:
>>
>>> 1: /*
>>
>> move jtreg tags below imports and add copyrights
>
> The copyright has been intentionally omitted as explained in
> https://bugs.openjdk.org/browse/JDK-82585
On Fri, 16 Aug 2024 11:40:20 GMT, Alexey Ivanov wrote:
>> As you mentioned, it's a good time to make a minor improvement, so I
>> modified the test.
>
> I propose not to edit the renamed files.
>
> First of all, the purpose of this PR is to *rename tests* to workaround a
> _misfeature_ of jtre
> Rename the tests to prevent unexpected deletion of result files when
> `-retain` jtreg option is specified.
> Testing: modified tests
toshiogata has updated the pull request incrementally with one additional
commit since the last revision:
Revert "Move jtreg tags and expand wildcard imports
On Fri, 16 Aug 2024 01:05:21 GMT, toshiogata wrote:
>> Rename the tests to prevent unexpected deletion of result files when
>> `-retain` jtreg option is specified.
>> Testing: modified tests
>
> toshiogata has updated the pull request incrementally with one additional
> commit since the last re
On Fri, 16 Aug 2024 01:01:52 GMT, toshiogata wrote:
>> test/langtools/tools/javac/generics/parametricException/ParametricException.java
>> line 1:
>>
>>> 1: /*
>>
>> since you're renaming this file for jtreg testing anyway could you move the
>> jtreg tags down below the imports and expand the
On Wed, 14 Aug 2024 23:43:14 GMT, Alisen Chung wrote:
>> toshiogata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move jtreg tags and expand wildcard imports
>
> test/langtools/tools/javac/generics/parametricException/ParametricExcepti
> Rename the tests to prevent unexpected deletion of result files when
> `-retain` jtreg option is specified.
> Testing: modified tests
toshiogata has updated the pull request incrementally with one additional
commit since the last revision:
Move jtreg tags and expand wildcard imports
--
On Tue, 6 Aug 2024 05:51:35 GMT, toshiogata wrote:
> Rename the tests to prevent unexpected deletion of result files when
> `-retain` jtreg option is specified.
> Testing: modified tests
test/langtools/tools/javac/generics/parametricException/ParametricException.java
line 1:
> 1: /*
since yo
On Tue, 6 Aug 2024 16:17:07 GMT, Magnus Ihse Bursie wrote:
> @jonathan-gibbons Is this a bug in jtreg, or where these files actually
> improperly named?
Not a bug as such, but maybe a little-known misfeature. `jtreg` has always had
problems with filenames that could cause confusion, and the ge
On Tue, 6 Aug 2024 05:51:35 GMT, toshiogata wrote:
> Rename the tests to prevent unexpected deletion of result files when
> `-retain` jtreg option is specified.
> Testing: modified tests
@jonathan-gibbons Is this a bug in jtreg, or where these files actually
improperly named?
-
P
Rename the tests to prevent unexpected deletion of result files when `-retain`
jtreg option is specified.
Testing: modified tests
-
Commit messages:
- Merge branch 'master' into 8337851
- 8337851: Some tests have name which confuse jtreg
Changes: https://git.openjdk.org/jdk/pull/2
20 matches
Mail list logo
