Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v4]

2024-10-16 Thread Sergey Bylokhov
> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been > tweaked, see inline comments. > > Notes: > * We have a few XXXRepaint.java tests and in this patch, I updated all of > them to follow the change added to the ListRepaint.java > > @azvegint @aivanov-jdk please tak

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v3]

2024-09-16 Thread Alexey Ivanov
On Mon, 9 Sep 2024 19:30:35 GMT, Alexey Ivanov wrote: >> Sergey Bylokhov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update bug4490179.java > > test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java line 53: > >> 51: >> 52: public

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v3]

2024-09-11 Thread Alexey Ivanov
On Tue, 10 Sep 2024 16:47:34 GMT, Alexander Zvegintsev wrote: >> Sergey Bylokhov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update bug4490179.java > > test/jdk/javax/swing/JButton/bug4490179.java line 86: > >> 84: robo

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v3]

2024-09-10 Thread Alexander Zvegintsev
On Tue, 10 Sep 2024 07:21:47 GMT, Sergey Bylokhov wrote: >> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have >> been tweaked, see inline comments. >> >> Notes: >> * We have a few XXXRepaint.java tests and in this patch, I updated all of >> them to follow the change add

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v3]

2024-09-10 Thread Alexey Ivanov
On Tue, 10 Sep 2024 07:21:47 GMT, Sergey Bylokhov wrote: >> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have >> been tweaked, see inline comments. >> >> Notes: >> * We have a few XXXRepaint.java tests and in this patch, I updated all of >> them to follow the change add

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v3]

2024-09-10 Thread Sergey Bylokhov
> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been > tweaked, see inline comments. > > Notes: > * We have a few XXXRepaint.java tests and in this patch, I updated all of > them to follow the change added to the ListRepaint.java > > @azvegint @aivanov-jdk please tak

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v2]

2024-09-09 Thread Sergey Bylokhov
> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been > tweaked, see inline comments. > > Notes: > * We have a few XXXRepaint.java tests and in this patch, I updated all of > them to follow the change added to the ListRepaint.java > > @azvegint @aivanov-jdk please tak

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401

2024-09-09 Thread Sergey Bylokhov
On Mon, 9 Sep 2024 20:34:30 GMT, Sergey Bylokhov wrote: >> Not sure if it's a product bug… >> >> AWT components do not explicitly state whether they're thread-safe or not. >> It's more or less assumed they should be. At the same time, I don't see code >> which ensures all the cases are thread-

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401

2024-09-09 Thread Sergey Bylokhov
On Mon, 9 Sep 2024 19:32:04 GMT, Alexey Ivanov wrote: >At the same time, I find it weird that repaint paints directly in its code and >then posts paint event. This is one of the implementation details of the AWT, the "native" component should be painted before the paint event will proceed on E

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401

2024-09-09 Thread Alexey Ivanov
On Mon, 9 Sep 2024 06:27:26 GMT, Sergey Bylokhov wrote: >> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have >> been tweaked, see inline comments. >> >> Notes: >> * We have a few XXXRepaint.java tests and in this patch, I updated all of >> them to follow the change adde

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401

2024-09-09 Thread Alexey Ivanov
On Wed, 4 Sep 2024 20:50:38 GMT, Sergey Bylokhov wrote: > Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been > tweaked, see inline comments. > > Notes: > * We have a few XXXRepaint.java tests and in this patch, I updated all of > them to follow the change added to t

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401

2024-09-09 Thread Sergey Bylokhov
On Wed, 4 Sep 2024 20:50:38 GMT, Sergey Bylokhov wrote: > Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been > tweaked, see inline comments. > > Notes: > * We have a few XXXRepaint.java tests and in this patch, I updated all of > them to follow the change added to t

RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401

2024-09-09 Thread Sergey Bylokhov
Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been tweaked, see inline comments. Notes: * We have a few XXXRepaint.java tests and in this patch, I updated all of them to follow the change added to the ListRepaint.java @azvegint @aivanov-jdk please take a look. -