Re: RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-26 Thread Laurent Bourgès
On Mon, 25 Aug 2025 19:33:57 GMT, Phil Race wrote: > trivial internal cleanup LGTM - PR Comment: https://git.openjdk.org/jdk/pull/26931#issuecomment-3222896979

Re: RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Phil Race
On Mon, 25 Aug 2025 21:06:42 GMT, Sergey Bylokhov wrote: > I was under impression that this was used to flush any errors printed before > initialization of toolkit, so it will not be conflicting with possible error > logs printed by the appkit thread. I suppose you infer that rather than someo

Re: RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Prasanta Sadhukhan
On Mon, 25 Aug 2025 19:33:57 GMT, Phil Race wrote: > trivial internal cleanup Update the copyright year if you may.. - Marked as reviewed by psadhukhan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26931#pullrequestreview-3153784546

Re: RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Sergey Bylokhov
On Mon, 25 Aug 2025 19:33:57 GMT, Phil Race wrote: > trivial internal cleanup I was under impression that this was used to flush any errors printed before initialization of toolkit, so it will not be conflicting with possible error logs printed by the appkit thread. - PR Comment:

RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Phil Race
trivial internal cleanup - Commit messages: - 8344333 Changes: https://git.openjdk.org/jdk/pull/26931/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26931&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344333 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod