On Mon, 28 Apr 2025 17:29:30 GMT, Rajat Mahajan wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code re
On Mon, 28 Apr 2025 17:29:30 GMT, Rajat Mahajan wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code re
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
code review suggestions
-
Changes:
- all: https://git.openjdk
On Mon, 28 Apr 2025 04:44:33 GMT, Rajat Mahajan wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code re
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
code review suggestions
-
Changes:
- all: https://git.openjdk
On Fri, 25 Apr 2025 20:06:05 GMT, Rajat Mahajan wrote:
>> test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 62:
>>
>>> 60: robot = new Robot();
>>> 61:
>>> 62: // Get all installed Look and Feels
>>
>> Huh, it was already there. Anyway.
>
> Sorry, I do not get this
On Fri, 25 Apr 2025 19:53:20 GMT, Alexey Ivanov wrote:
>> Rajat Mahajan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java
>>
>> Co-authored-by: Alexey Ivanov
>
> test/j
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java
Co-auth
On Fri, 25 Apr 2025 19:52:06 GMT, Rajat Mahajan wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> Rajat Mahajan has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Upda
On Fri, 25 Apr 2025 16:55:40 GMT, Rajat Mahajan wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code ch
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Rajat Mahajan has updated the pull request incrementally with five additional
commits since the last revision:
- Update test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java
Co
On Fri, 25 Apr 2025 16:55:40 GMT, Rajat Mahajan wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code ch
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
code changes as per code review
-
Changes:
- all: https://git
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
made changes according to suggestions in code review
-
Changes:
On Tue, 15 Apr 2025 19:53:34 GMT, Harshitha Onkar wrote:
> LGTM apart from minor inline suggestion.
>
> Since the test has lot of tab movements, does CI testing look good on all
> platforms on multiple runs (repeat) ?
Yes, it looks good on multiple runs.
-
PR Comment: https://git
On Thu, 17 Apr 2025 19:49:48 GMT, Abhishek Kumar wrote:
> > #23964 (comment)
>
> Will take a look soon.
Changes looks good to me apart from your suggestions.
-
PR Comment: https://git.openjdk.org/jdk/pull/24384#issuecomment-2815963933
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote:
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
> #23964 (comment)
Will take a look soon.
-
PR Comment: https://git.openjdk.org/jdk/pull/24384#issuecomment-2813876135
On Thu, 17 Apr 2025 16:35:59 GMT, Alexey Ivanov wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 301:
>
>> 299: private static boolean actRB1 = false;
>> 3
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote:
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
For the sake of completeness, the description could've mentioned that
@kumarabhi006 requested these changes in
https://github.com/op
On Tue, 15 Apr 2025 19:49:43 GMT, Harshitha Onkar wrote:
>> Details:
>> Refactored code as requested in the Bug description.
>>
>> Tested and verified the test passes.
>
> test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 181:
>
>> 179: mainFrame.getContentPane()
>> 180:
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote:
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Overall, it looks good to me.
Except for the minor comments that I left, I can suggest:
- removing `System.out.println` before throw
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote:
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Marked as reviewed by dmarkov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24384#pullrequestreview-27720170
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote:
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
LGTM apart from minor inline suggestion.
Since the test has lot of tab movements, does CI testing look good on all
platforms on mult
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote:
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Can someone please review this? , it has been more than 10 days that it has
been out there.
Thank you!
-
PR Comment: h
Details:
Refactored code as requested in the Bug description.
Tested and verified the test passes.
-
Commit messages:
- 8351884: Refactor bug8033699.java test code
- 8351884: Refactor bug8033699.java test code
Changes: https://git.openjdk.org/jdk/pull/24384/files
Webrev: https:/
25 matches
Mail list logo
